--===============4323007365939678712== Content-Type: multipart/alternative; boundary="===============0023514354860449625==" --===============0023514354860449625== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review54431 ----------------------------------------------------------- See inline comment about line breaks. Also, the disabling of the buttons isn't in this patch. For reviewers, it's more convenient if you fix all the issues pointed out, and then upload a new patch. mediaelements/playlist/Playlist.qml brackets go on the same line as the if statement - Sebastian Kügler On March 28, 2014, 12:39 p.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116874/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 12:39 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 330990 and Bug > http://bugs.kde.org/show_bug.cgi?id=330990 > http://bugs.kde.org/show_bug.cgi?id=Bug > > > Repository: plasma-mediacenter > > > Description > ------- > > Now the next and previous buttons do not work unless a media is playing. > > > Diffs > ----- > > mediaelements/playlist/Playlist.qml 5dde297 > > Diff: https://git.reviewboard.kde.org/r/116874/diff/ > > > Testing > ------- > > I've done the testing for this patch. > > These are the steps that I followed. > 1. Added a new playlist and added a few songs to the playlist. > 2. Re-opened Plasma Media Center > 3. Clicked the Next and Previous buttons. > 4. Nothing was played. > 5. Selected a song from the list and then tested the next and previous buttons. > 6. The buttons worked seamlessly. > > > Thanks, > > R.Harish Navnit > > --===============0023514354860449625== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/

See inline comment about line breaks. Also, the disabling of the buttons isn't in this patch.

For reviewers, it's more convenient if you fix all the issues pointed out, and then upload a new patch.

mediaelements/playlist/Playlist.qml (Diff revision 4)
		175	{

brackets go on the same line as the if statement

- Sebastian Kügler

On March 28th, 2014, 12:39 p.m. UTC, R.Harish Navnit wrote:

Review request for Plasma, Shantanu Tushar and Sinny Kumari.

By R.Harish Navnit.

Updated March 28, 2014, 12:39 p.m.

Bugs: 330990, Bug

Repository: plasma-mediacenter

Description

Now the next and previous buttons do not work unless a media is playing.

Testing

I've done the testing for this patch.

These are the steps that I followed. 
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center 
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous buttons.
6. The buttons worked seamlessly.

Diffs

mediaelements/playlist/Playlist.qml (5dde297)

--===============0023514354860449625==-- --===============4323007365939678712== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4323007365939678712==--