This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ 

See inline comment about line breaks. Also, the disabling of the buttons isn't in this patch.

For reviewers, it's more convenient if you fix all the issues pointed out, and then upload a new patch.

mediaelements/playlist/Playlist.qml (Diff revision 4) 

    175
    
        {

  


 





brackets go on the same line as the if statement









- Sebastian Kügler






On March 28th, 2014, 12:39 p.m. UTC, R.Harish  Navnit wrote:











 

  


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


By R.Harish  Navnit.




Updated March 28, 2014, 12:39 p.m.










 Bugs: 


 330990, 

 Bug









 Repository: 
plasma-mediacenter





Description 

 

 

  
   
Now the next and previous buttons do not work unless a media is playing. 

  		
 






Testing 



 

  
   
I've done the testing for this patch.

These are the steps that I followed. 
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center 
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous buttons.
6. The buttons worked seamlessly.  

  		
 






Diffs 


    

 
  • mediaelements/playlist/Playlist.qml (5dde297)
    • 





View Diff