'Re: Review Request 117121: Add property to determine if popups should be inside or outside the paren'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117121: Add property to determine if popups should be inside or outside the paren
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-03-27 17:57:15
Message-ID: 20140327175715.24148.83222 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117121/#review54355
-----------------------------------------------------------

"break" as in.. ?

- Marco Martin

On March 27, 2014, 5:34 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117121/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 5:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add property to determine if popups should be inside or outside the parentItem
> 
> For some cases of dialog we want to position within the parent item for
> example widget explorer. For popup applets on the desktop the dialog
> should appear outside of the parentItem.
> 
> Currently we try to determine it automatically from the window type of
> the parentItem. This worked fine for widget explorer and panels, but
> breaks for popup applets on the desktop.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.h 3804d18 
>   src/plasmaquick/dialog.cpp 77c0c8c 
> 
> Diff: https://git.reviewboard.kde.org/r/117121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117121/">https://git.reviewboard.kde.org/r/117121/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">&quot;break&quot; as \
in.. ?</pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On March 27th, 2014, 5:34 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated March 27, 2014, 5:34 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add property to determine if popups should be inside or outside the \
parentItem

For some cases of dialog we want to position within the parent item for
example widget explorer. For popup applets on the desktop the dialog
should appear outside of the parentItem.

Currently we try to determine it automatically from the window type of
the parentItem. This worked fine for widget explorer and panels, but
breaks for popup applets on the desktop.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasmaquick/dialog.h <span style="color: grey">(3804d18)</span></li>

 <li>src/plasmaquick/dialog.cpp <span style="color: grey">(77c0c8c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117121/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 