[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playl
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2014-03-27 13:05:27
Message-ID: 20140327130527.3055.48357 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review54293
-----------------------------------------------------------
If a button doesn't do anything, it should be indicated by disabling it, not just \
making it a no-op.
mediaelements/playlist/Playlist.qml
<https://git.reviewboard.kde.org/r/116874/#comment37984>
Add { } to the if statement, it makes the code easier to read, and prevents \
errors when people insert a line without adjusting {}
It's also Plasma's recommended coding style.
mediaelements/playlist/Playlist.qml
<https://git.reviewboard.kde.org/r/116874/#comment37985>
indenting is wrong now
- Sebastian Kügler
On March 27, 2014, 11:22 a.m., R.Harish Navnit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116874/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 11:22 a.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Bugs: 330990 and Bug
> http://bugs.kde.org/show_bug.cgi?id=330990
> http://bugs.kde.org/show_bug.cgi?id=Bug
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Now the next and previous buttons do not work unless a media is playing.
>
>
> Diffs
> -----
>
> mediaelements/playlist/Playlist.qml fd83c21
>
> Diff: https://git.reviewboard.kde.org/r/116874/diff/
>
>
> Testing
> -------
>
> I've done the testing for this patch.
>
> These are the steps that I followed.
> 1. Added a new playlist and added a few songs to the playlist.
> 2. Re-opened Plasma Media Center
> 3. Clicked the Next and Previous buttons.
> 4. Nothing was played.
> 5. Selected a song from the list and then tested the next and previous buttons.
> 6. The buttons worked seamlessly.
>
>
> File Attachments
> ----------------
>
> pulled the latest source and made changes
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch
>
>
> Thanks,
>
> R.Harish Navnit
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116874/">https://git.reviewboard.kde.org/r/116874/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If a button doesn't \
do anything, it should be indicated by disabling it, not just making it a \
no-op.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116874/diff/3/?file=257374#file257374line158" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/playlist/Playlist.qml</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">158</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span><span class="nx">playlistModel</span><span \
class="p">.</span><span class="nx">currentIndex</span> <span class="o">!=</span> \
<span class="o">-</span><span class="mi">1</span><span class="p">)</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add { } to \
the if statement, it makes the code easier to read, and prevents errors when people \
insert a line without adjusting {}
It's also Plasma's recommended coding style.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116874/diff/3/?file=257374#file257374line159" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/playlist/Playlist.qml</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">158</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">playlistList</span><span class="p">.</span><span \
class="nx">currentItem</span><span class="p">.</span><span \
class="nx">requestPlayback</span><span class="p">();</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">159</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">playlistList</span><span class="p">.</span><span \
class="nx">currentItem</span><span class="p">.</span><span \
class="nx">requestPlayback</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">indenting \
is wrong now</pre> </div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On March 27th, 2014, 11:22 a.m. UTC, R.Harish Navnit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By R.Harish Navnit.</div>
<p style="color: grey;"><i>Updated March 27, 2014, 11:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330990">330990</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=Bug">Bug</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now the next and previous buttons do not work unless a media is playing. \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've done the testing for this patch.
These are the steps that I followed.
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous buttons.
6. The buttons worked seamlessly. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/playlist/Playlist.qml <span style="color: \
grey">(fd83c21)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116874/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch">pulled \
the latest source and made changes</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic