[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116983: Fix the height of the buttonsbar
From: "Giorgos Tsiapaliokas" <giorgos.tsiapaliokas () Kde ! org>
Date: 2014-03-24 10:26:24
Message-ID: 20140324102624.31758.27817 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116983/
-----------------------------------------------------------
(Updated March 24, 2014, 12:26 p.m.)
Review request for Plasma.
Changes
-------
I have removed the margins because they were pushing the buttons away from the
background and also I don't think that they should exist.
I have attached another screenshot in which the buttons and the background align \
correctly.
Here the refreshButton has implicitHeight 26 and the background 52(tested with \
console.log) but the background doesn't seem to have 52, its more like 26(see the \
image without_margins.png).
Repository: plasmate
Description
-------
If I am not mistaken a regression has been introduced in plasmoidviewer.
This patch solves the issue.
Diffs (updated)
-----
plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5
Diff: https://git.reviewboard.kde.org/r/116983/diff/
Testing
-------
I have attached two images 1 without my patch and one with my patch
File Attachments (updated)
----------------
after.png
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png
before.png
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png
plasmoidviewer without margins
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/19f7cde7-7736-4199-b4f6-938b5fd75772__without_margins.png
Thanks,
Giorgos Tsiapaliokas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116983/">https://git.reviewboard.kde.org/r/116983/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated March 24, 2014, 12:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have removed the margins because they were pushing the buttons away \
from the background and also I don't think that they should exist.
I have attached another screenshot in which the buttons and the background align \
correctly.
Here the refreshButton has implicitHeight 26 and the background 52(tested with \
console.log) but the background doesn't seem to have 52, its more like 26(see the \
image without_margins.png).</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If I am not mistaken a regression has been introduced in plasmoidviewer. \
This patch solves the issue.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have attached two images 1 without my patch and one with my \
patch</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <span style="color: \
grey">(c3624a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116983/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png">after.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png">before.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/19f7cde7-7736-4199-b4f6-938b5fd75772__without_margins.png">plasmoidviewer \
without margins</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic