[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-03-24 9:34:44
Message-ID: 20140324093444.31758.33326 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116956/#review53930
-----------------------------------------------------------
what about just renaming the installed targets? I don't see a benefit in renaming the \
desktop files, etc. in the source dir. Otherwise we will have to rename again with \
kglobalaccel6
- Martin Gräßlin
On March 21, 2014, 5:35 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116956/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 5:35 p.m.)
>
>
> Review request for KDE Runtime, Plasma and Martin Gräßlin.
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> kde-runtime will soon get an alpha release. Because both KF5 and kdelibs4 \
> applications should be able to be installed and run it should be co-installable \
> with kde-runtime from KDE 4 times. Starting at the top of the cmake file I've \
> renamed kglobalaccel to see if it's sane to do so.
>
> Diffs
> -----
>
> kglobalaccel/org.kde.kglobalaccel.service.in d8576b0
> kglobalaccel/CMakeLists.txt 8bc8bea
> kglobalaccel/kglobalaccel.desktop a61516e
> kglobalaccel/kglobalaccel.notifyrc 9e3ecd3
> kglobalaccel/kglobalaccel5.desktop PRE-CREATION
> kglobalaccel/kglobalaccel5.notifyrc PRE-CREATION
> kglobalaccel/main.cpp d788b64
>
> Diff: https://git.reviewboard.kde.org/r/116956/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116956/">https://git.reviewboard.kde.org/r/116956/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what about just renaming \
the installed targets? I don't see a benefit in renaming the desktop files, etc. \
in the source dir. Otherwise we will have to rename again with kglobalaccel6</pre> \
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On March 21st, 2014, 5:35 p.m. CET, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime, Plasma and Martin Gräßlin.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated March 21, 2014, 5:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kde-runtime will soon get an alpha release. Because both KF5 and \
kdelibs4 applications should be able to be installed and run it should be \
co-installable with kde-runtime from KDE 4 times. Starting at the top of the cmake \
file I've renamed kglobalaccel to see if it's sane to do so. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kglobalaccel/org.kde.kglobalaccel.service.in <span style="color: \
grey">(d8576b0)</span></li>
<li>kglobalaccel/CMakeLists.txt <span style="color: grey">(8bc8bea)</span></li>
<li>kglobalaccel/kglobalaccel.desktop <span style="color: \
grey">(a61516e)</span></li>
<li>kglobalaccel/kglobalaccel.notifyrc <span style="color: \
grey">(9e3ecd3)</span></li>
<li>kglobalaccel/kglobalaccel5.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kglobalaccel/kglobalaccel5.notifyrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kglobalaccel/main.cpp <span style="color: grey">(d788b64)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116956/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic