'Re: Review Request 116931: Make sure kdeinit starts kded'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116931: Make sure kdeinit starts kded
From:       Àlex_Fiestas <afiestas () kde ! org>
Date:       2014-03-20 21:06:25
Message-ID: 20140320210625.6642.39056 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On March 20, 2014, 4:29 p.m., Àlex Fiestas wrote:
> > kdeinit should be launching kded, if not what has changed?
> 
> Alex Merry wrote:
> https://git.reviewboard.kde.org/r/116928/ changes it to not load it by default, so \
> that applications running outside of Plasma don't run it just because they wanted a \
> kioslave.  It should still be auto-started if anything tries to use one of its \
> D-Bus interfaces, though.

good stuff!

- Àlex

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116931/#review53532
-----------------------------------------------------------

On March 20, 2014, 7:31 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116931/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 7:31 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Make sure kdeinit starts kded
> 
> We now have to explicitly tell kdeinit to start kded using the --kded
> option (as of https://git.reviewboard.kde.org/r/116928/).
> 
> 
> Diffs
> -----
> 
> plasma-workspace/startkde/startkde.cmake 86abf5b68dc5717d9fc257e0d442242fc18d3058 
> 
> Diff: https://git.reviewboard.kde.org/r/116931/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116931/">https://git.reviewboard.kde.org/r/116931/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 20th, 2014, 4:29 p.m. UTC, <b>Àlex \
Fiestas</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdeinit should be launching kded, if not what has changed?</pre>  \
</blockquote>

 <p>On March 20th, 2014, 6:09 p.m. UTC, <b>Alex Merry</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">https://git.reviewboard.kde.org/r/116928/ changes it to not load it by \
default, so that applications running outside of Plasma don&#39;t run it just because \
they wanted a kioslave.  It should still be auto-started if anything tries to use one \
of its D-Bus interfaces, though.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good stuff!</pre> <br />

<p>- Àlex</p>

<br />
<p>On March 20th, 2014, 7:31 p.m. UTC, Alex Merry wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Alex Merry.</div>

<p style="color: grey;"><i>Updated March 20, 2014, 7:31 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make sure kdeinit starts kded

We now have to explicitly tell kdeinit to start kded using the --kded
option (as of https://git.reviewboard.kde.org/r/116928/).</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma-workspace/startkde/startkde.cmake <span style="color: \
grey">(86abf5b68dc5717d9fc257e0d442242fc18d3058)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116931/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 