[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
From:       "Harshit Agarwal" <see.harshit () gmail ! com>
Date:       2014-03-20 14:46:22
Message-ID: 20140320144622.10227.54735 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116554/
-----------------------------------------------------------

(Updated March 20, 2014, 2:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.


Repository: plasma-mediacenter


Description
-------

Referring to Bug #331040 The functionality of the media starting to play on the press \
of the "Play All" button has been implemented. It has been noted and implemented that \
the media doesn't start over when new songs/videos are added to an existing playlist. \



Diffs
-----

  browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 
  shells/newshell/mainwindow.h f224060 
  shells/newshell/mainwindow.cpp f721d68 
  shells/newshell/package/contents/ui/mediacenter.qml bac33c2 

Diff: https://git.reviewboard.kde.org/r/116554/diff/


Testing
-------

The testing has been done through various test scenarios.


Thanks,

Harshit Agarwal


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116554/">https://git.reviewboard.kde.org/r/116554/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and \
Sujith Haridasan.</div> <div>By Harshit Agarwal.</div>


<p style="color: grey;"><i>Updated March 20, 2014, 2:46 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Referring to Bug #331040 The functionality of the media starting to play \
on the press of the &quot;Play All&quot; button has been implemented. It has been \
noted and implemented that the media doesn&#39;t start over when new songs/videos are \
added to an existing playlist. </pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The testing has been done through various test scenarios.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: \
grey">(faaafa7)</span></li>

 <li>shells/newshell/mainwindow.h <span style="color: grey">(f224060)</span></li>

 <li>shells/newshell/mainwindow.cpp <span style="color: grey">(f721d68)</span></li>

 <li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(bac33c2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116554/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic