[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor
From: "Ashish Madeti" <ashishmadeti () gmail ! com>
Date: 2014-03-20 5:47:56
Message-ID: 20140320054756.16294.44341 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 20, 2014, 11 a.m., Sujith Haridasan wrote:
> > Ashish can you explain why do we need session bus for every single adaptor? Just \
> > wanted to know what advantage would that make?
We need to register each adaptor on session bus separately (i.e in their respective \
constructors) because if we register all the adaptors at one go, say in the \
constructor of MPRIS class, we will not be able to handle the events in a particular \
adaptor from QML (as QML will create a separate instance which has not been \
registered on sessionBus). Therefore, we use MPRIS adaptor only to register PMC as a \
service on session bus. Each adaptor registers itself as an object from its own \
constructor.
PS: If we find that some adaptor has no relation whatsoever with QML, then we can \
register it right from MPRIS class (as a future change).
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/#review53474
-----------------------------------------------------------
On March 19, 2014, 10:52 p.m., Ashish Madeti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116907/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 10:52 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Implemented "Player" DBus adaptor of MPRIS specifications for Plasma Mediacenter.
> Specification reference: \
> http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
> Some more work needs to be done in the adaptor which I plan to do soon.
>
>
> Diffs
> -----
>
> libs/mpris2/mediaplayer2.h e68bc5c
> libs/mpris2/mediaplayer2.cpp ff96618
> libs/mpris2/mediaplayer2player.h 203d681
> libs/mpris2/mediaplayer2player.cpp 7871efa
> libs/mpris2/mpris2.cpp a8ad3ef
> shells/newshell/mainwindow.cpp d2d71d4
> shells/newshell/package/contents/ui/mediacenter.qml bac33c2
>
> Diff: https://git.reviewboard.kde.org/r/116907/diff/
>
>
> Testing
> -------
>
> Tested with qdbusviewer, the properties and methods are working fine.
>
>
> Thanks,
>
> Ashish Madeti
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116907/">https://git.reviewboard.kde.org/r/116907/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 20th, 2014, 11 a.m. IST, <b>Sujith \
Haridasan</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ashish can you explain why do we need session bus for every single \
adaptor? Just wanted to know what advantage would that make?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We need to register each \
adaptor on session bus separately (i.e in their respective constructors) because if \
we register all the adaptors at one go, say in the constructor of MPRIS class, we \
will not be able to handle the events in a particular adaptor from QML (as QML will \
create a separate instance which has not been registered on sessionBus). Therefore, \
we use MPRIS adaptor only to register PMC as a service on session bus. Each adaptor \
registers itself as an object from its own constructor.
PS: If we find that some adaptor has no relation whatsoever with QML, then we can \
register it right from MPRIS class (as a future change).</pre> <br />
<p>- Ashish</p>
<br />
<p>On March 19th, 2014, 10:52 p.m. IST, Ashish Madeti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Ashish Madeti.</div>
<p style="color: grey;"><i>Updated March 19, 2014, 10:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implemented "Player" DBus adaptor of MPRIS specifications for \
Plasma Mediacenter. Specification reference: \
http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
Some more work needs to be done in the adaptor which I plan to do soon.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with qdbusviewer, the properties and methods are working \
fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mpris2/mediaplayer2.h <span style="color: grey">(e68bc5c)</span></li>
<li>libs/mpris2/mediaplayer2.cpp <span style="color: grey">(ff96618)</span></li>
<li>libs/mpris2/mediaplayer2player.h <span style="color: grey">(203d681)</span></li>
<li>libs/mpris2/mediaplayer2player.cpp <span style="color: \
grey">(7871efa)</span></li>
<li>libs/mpris2/mpris2.cpp <span style="color: grey">(a8ad3ef)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(d2d71d4)</span></li>
<li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(bac33c2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116907/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic