[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116625: Oxygen as default font
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2014-03-19 9:23:10
Message-ID: 20140319092310.10295.5856 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 19, 2014, 1:16 a.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch master.
>
> Hrvoje Senjan wrote:
> i was under the impression that consensus was to go with (only) r116633.
> at least kdeglobals injection *should not* be needed with frameworkintegration \
> change. or am i missing something?
> Sebastian Kügler wrote:
> r116633 is not enough, since it only sets the face and size of the font, but not \
> its rendering method. (The XftHint, basically.) We technically don't need to set \
> the face and size here, I just did it for completeness sake, but we can't remove \
> this bit entirely, since the rendering method would otherwise not be set, and the \
> font rendering would be unknown.
(Just realized that I had written an explanation earlier, but hadn't hit "publish", \
I've done that now. Sorry for the confusion.)
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116625/#review53378
-----------------------------------------------------------
On March 19, 2014, 1:16 a.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116625/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 1:16 a.m.)
>
>
> Review request for Plasma and Àlex Fiestas.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Make Oxygen the default font
>
> This has three portions: the fonts itself, installation of them including
> fontconfig bits, and setting font defaults in kdeglobals.
>
> Oxygen Font 0.4 Imported from oxygen-font repository.
>
> The startkde portion contains the bits to write out a kdeglobals default
> file if it doesn't exist with font settings applied. Usually, with install
> prefix set to /usr, the installed oxygen font is found automatically by
> fontconfig. If we're installed to a different prefix, we need to point
> fontconfig at the font. We do that by linking it from either
> XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
> irrelevant for systems that install into /usr.
>
>
> Diffs
> -----
>
> CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0
> fonts/CMakeLists.txt PRE-CREATION
> fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION
> fonts/oxygen/GPL.txt PRE-CREATION
> fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION
> fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION
> fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION
> fonts/oxygen/README PRE-CREATION
> startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303
>
> Diff: https://git.reviewboard.kde.org/r/116625/diff/
>
>
> Testing
> -------
>
> Logged into session with clean config. Font settings are applied correctly \
> throughout.
>
> Thanks,
>
> Sebastian Kügler
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116625/">https://git.reviewboard.kde.org/r/116625/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 19th, 2014, 1:16 a.m. UTC, <b>Commit \
Hook</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch master.</pre> \
</blockquote>
<p>On March 19th, 2014, 2:42 a.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i was under the \
impression that consensus was to go with (only) r116633. at least kdeglobals \
injection *should not* be needed with frameworkintegration change. or am i missing \
something?</pre> </blockquote>
<p>On March 19th, 2014, 9:22 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">r116633 is not enough, \
since it only sets the face and size of the font, but not its rendering method. (The \
XftHint, basically.) We technically don't need to set the face and size here, I \
just did it for completeness sake, but we can't remove this bit entirely, since \
the rendering method would otherwise not be set, and the font rendering would be \
unknown.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(Just realized that I \
had written an explanation earlier, but hadn't hit "publish", I've \
done that now. Sorry for the confusion.)</pre> <br />
<p>- Sebastian</p>
<br />
<p>On March 19th, 2014, 1:16 a.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Àlex Fiestas.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated March 19, 2014, 1:16 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make Oxygen the default font
This has three portions: the fonts itself, installation of them including
fontconfig bits, and setting font defaults in kdeglobals.
Oxygen Font 0.4 Imported from oxygen-font repository.
The startkde portion contains the bits to write out a kdeglobals default
file if it doesn't exist with font settings applied. Usually, with install
prefix set to /usr, the installed oxygen font is found automatically by
fontconfig. If we're installed to a different prefix, we need to point
fontconfig at the font. We do that by linking it from either
XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
irrelevant for systems that install into /usr.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Logged into session with clean config. Font settings are applied \
correctly throughout.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(0135bb1f7475862451775928adf5dc20167424e0)</span></li>
<li>fonts/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>fonts/oxygen/COPYING-GPL+FE.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>fonts/oxygen/GPL.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>fonts/oxygen/Oxygen-Sans-Bold.ttf <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>fonts/oxygen/Oxygen-Sans.ttf <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>fonts/oxygen/OxygenMono-Regular.ttf <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>fonts/oxygen/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>startkde.cmake <span style="color: \
grey">(53d1bc6a2098f634c5f386f95e1a1c504b554303)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116625/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic