'Re: Review Request 116869: Completely remove the legacy ksmserver shutdown effect'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116869: Completely remove the legacy ksmserver shutdown effect
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-03-18 16:33:01
Message-ID: 20140318163301.4860.84379 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116869/
-----------------------------------------------------------

(Updated March 18, 2014, 4:33 p.m.)

Status
------

This change has been marked as submitted.

Review request for kwin, Plasma, Àlex Fiestas, and Teo Mrnjavac.

Repository: kde-workspace

Description
-------

Completely remove the legacy ksmserver shutdown effect

Painting was already disabled in the effect inside ksmserver, thus it
was more or less dead code. Let's remove it completely.

This also allows to remove the "temporary" hack inside KWin's logout
effect.

Diffs
-----

  kwin/effects/logout/logout.cpp 599efcd2156800ec1d8bfa8fb99bb7b074628fdb 
  ksmserver/tests/test.cpp b69bc6ee065bcafc671b7fd44a98f7e832d8b1bd 
  ksmserver/shutdowndlg.h 9a33a046d1a634bedf3a7367ee16b60836771d9d 
  ksmserver/shutdowndlg.cpp feeedbeb5ea4b80c79e8888d4105fed4784bc70c 
  ksmserver/shutdown.cpp e193ef73b6e540db72b3133e148d4c248929362a 

Diff: https://git.reviewboard.kde.org/r/116869/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116869/">https://git.reviewboard.kde.org/r/116869/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Plasma, Àlex Fiestas, and Teo Mrnjavac.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 18, 2014, 4:33 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Completely remove the legacy ksmserver shutdown effect

Painting was already disabled in the effect inside ksmserver, thus it
was more or less dead code. Let&#39;s remove it completely.

This also allows to remove the &quot;temporary&quot; hack inside KWin&#39;s logout
effect.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/logout/logout.cpp <span style="color: \
grey">(599efcd2156800ec1d8bfa8fb99bb7b074628fdb)</span></li>

 <li>ksmserver/tests/test.cpp <span style="color: \
grey">(b69bc6ee065bcafc671b7fd44a98f7e832d8b1bd)</span></li>

 <li>ksmserver/shutdowndlg.h <span style="color: \
grey">(9a33a046d1a634bedf3a7367ee16b60836771d9d)</span></li>

 <li>ksmserver/shutdowndlg.cpp <span style="color: \
grey">(feeedbeb5ea4b80c79e8888d4105fed4784bc70c)</span></li>

 <li>ksmserver/shutdown.cpp <span style="color: \
grey">(e193ef73b6e540db72b3133e148d4c248929362a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116869/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 