'Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet
From:       "Yichao Zhou" <broken.zhou () gmail ! com>
Date:       2014-03-18 12:56:57
Message-ID: 20140318125657.4860.54936 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115431/
-----------------------------------------------------------

(Updated March 18, 2014, 12:56 p.m.)

Review request for Plasma.

Bugs: 228902
    http://bugs.kde.org/show_bug.cgi?id=228902

Repository: kde-workspace

Description
-------

For bug, see
https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and
https://bugs.kde.org/show_bug.cgi?id=228902

The problem is that in original code, it always uses 23:59 to calculate the width of \
the text.  However, in some font, AM is wider than PM, and 0 is wider than 2 and 5.  \
That causes some fonts been cropped.

Diffs (updated)
-----

  plasma/generic/applets/digital-clock/clock.cpp f26e328 

Diff: https://git.reviewboard.kde.org/r/115431/diff/

Testing
-------

Thanks,

Yichao Zhou

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115431/">https://git.reviewboard.kde.org/r/115431/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Yichao Zhou.</div>

<p style="color: grey;"><i>Updated March 18, 2014, 12:56 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=228902">228902</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For bug, see \
https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and \
https://bugs.kde.org/show_bug.cgi?id=228902

The problem is that in original code, it always uses 23:59 to calculate the width of \
the text.  However, in some font, AM is wider than PM, and 0 is wider than 2 and 5.  \
That causes some fonts been cropped.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/digital-clock/clock.cpp <span style="color: \
grey">(f26e328)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115431/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 