[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114566: Plasmate: Port remoteinstaller to Qt5/KF5
From: "Commit Hook" <null () kde ! org>
Date: 2014-03-17 11:51:13
Message-ID: 20140317115113.13830.16156 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114566/#review53171
-----------------------------------------------------------
This review has been submitted with commit 805084d5aad25d41a413f630ddf328d6adaea0db \
by Antonis Tsiapaliokas to branch frameworks.
- Commit Hook
On Jan. 5, 2014, 5:36 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114566/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2014, 5:36 p.m.)
>
>
> Review request for Plasma and Giorgos Tsiapaliokas.
>
>
> Repository: plasmate
>
>
> Description
> -------
>
> Hello,
>
> This patch ports the remoteinstaller to Qt5/KF5.
>
>
> Diffs
> -----
>
> plasmate/CMakeLists.txt 55e7453
> plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97
> plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33
>
> Diff: https://git.reviewboard.kde.org/r/114566/diff/
>
>
> Testing
> -------
>
> I wasn't able to test if it works. Because remoteinstaller is using the \
> KUrlRequester, which it segfaults... I have open a thread on the frameworks ML.
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114566/">https://git.reviewboard.kde.org/r/114566/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 805084d5aad25d41a413f630ddf328d6adaea0db by Antonis \
Tsiapaliokas to branch frameworks.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On January 5th, 2014, 5:36 p.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Giorgos Tsiapaliokas.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2014, 5:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This patch ports the remoteinstaller to Qt5/KF5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I wasn't able to test if it works. Because remoteinstaller is using \
the KUrlRequester, which it segfaults... I have open a thread on the frameworks \
ML.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/CMakeLists.txt <span style="color: grey">(55e7453)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(5f4de97)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: \
grey">(3b41b33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114566/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic