[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-03-07 10:08:42
Message-ID: 20140307100842.2613.3961 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 7, 2014, 10:52 a.m., David Edmundson wrote:
> > File Attachment: New advanced compositing KCM - kcmcompositing.png
> > <https://git.reviewboard.kde.org/r/116648/#fcomment171>
> >
> > Double margin?
Looks like this is in kcmshell
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116648/#review52327
-----------------------------------------------------------
On March 7, 2014, 10:20 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116648/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 10:20 a.m.)
>
>
> Review request for kwin, Plasma and Antonis Tsiapaliokas.
>
>
> Repository: kwin-compositing-kcm
>
>
> Description
> -------
>
> Split into one KCM for Desktop Effects and one for Compositing
>
> Let's try getting the KCM a little bit less scary by properly
> hiding everything the user doesn't have to care about. The prominent
> desktop effects KCM only contains the list of all the effects which
> can be configured and nothing else. Only exception is the disabled
> check after failed GL to make this easier for the user.
>
> All the "advanced" settings are moved into a new KCM called
> "Compositing" which is put under the hardware component in
> systemsettings. This contains all advanced settings including
> * whether compositing is enabled at all
> * backend
> * animation speeed
> * scale filter
> * unredirect fullscreen
> * color correction
>
>
> Diffs
> -----
>
> CMakeLists.txt 90d27a02f691d500662754658518d1e99cfbc022
> kcmkwineffects.desktop PRE-CREATION
> kwincompositing.desktop 88ecf46b393df947d6b59ce53c924a82fc65756a
> main.cpp 5c68722961be9b8a0a48f3221df7c033ba3cf946
> model.h c047677fed50606b194049734afeb87cbcc385cb
> model.cpp 2b25fe04ccacf0fb719956b1b5fa0267611747e6
> qml/CompositingView.qml PRE-CREATION
> qml/EffectView.qml 1c9d3a6d292c589bd4ab31d4c6071f2b4ff658c3
> qml/main-compositing.qml PRE-CREATION
> qml/main.qml d22dd08da529df938d99ff9d43f52f7b33a7f2d3
>
> Diff: https://git.reviewboard.kde.org/r/116648/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> New advanced compositing KCM
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png
> New effects KCM
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116648/">https://git.reviewboard.kde.org/r/116648/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 7th, 2014, 10:52 a.m. CET, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td>
<a href="https://git.reviewboard.kde.org/r/116648/file/1100/" style="color: \
black; font-weight: bold; font-size: 9pt;">kcmcompositing.png</a>
<p>New advanced compositing KCM</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Double margin?</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like \
this is in kcmshell</pre> <br />
<p>- Martin</p>
<br />
<p>On March 7th, 2014, 10:20 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma and Antonis Tsiapaliokas.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 7, 2014, 10:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin-compositing-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Split into one KCM for Desktop Effects and one for Compositing
Let's try getting the KCM a little bit less scary by properly
hiding everything the user doesn't have to care about. The prominent
desktop effects KCM only contains the list of all the effects which
can be configured and nothing else. Only exception is the disabled
check after failed GL to make this easier for the user.
All the "advanced" settings are moved into a new KCM called
"Compositing" which is put under the hardware component in
systemsettings. This contains all advanced settings including
* whether compositing is enabled at all
* backend
* animation speeed
* scale filter
* unredirect fullscreen
* color correction</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(90d27a02f691d500662754658518d1e99cfbc022)</span></li>
<li>kcmkwineffects.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwincompositing.desktop <span style="color: \
grey">(88ecf46b393df947d6b59ce53c924a82fc65756a)</span></li>
<li>main.cpp <span style="color: \
grey">(5c68722961be9b8a0a48f3221df7c033ba3cf946)</span></li>
<li>model.h <span style="color: \
grey">(c047677fed50606b194049734afeb87cbcc385cb)</span></li>
<li>model.cpp <span style="color: \
grey">(2b25fe04ccacf0fb719956b1b5fa0267611747e6)</span></li>
<li>qml/CompositingView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/EffectView.qml <span style="color: \
grey">(1c9d3a6d292c589bd4ab31d4c6071f2b4ff658c3)</span></li>
<li>qml/main-compositing.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/main.qml <span style="color: \
grey">(d22dd08da529df938d99ff9d43f52f7b33a7f2d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116648/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png">New \
advanced compositing KCM</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png">New \
effects KCM</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic