[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon
From: "Commit Hook" <null () kde ! org>
Date: 2014-03-05 11:49:40
Message-ID: 20140305114940.30662.67287 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review52056
-----------------------------------------------------------
This review has been submitted with commit a6c75f16514a2f8bb537f557bf8a07e957199171 \
by Martin Gräßlin to branch master.
- Commit Hook
On March 5, 2014, 11:14 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 11:14 a.m.)
>
>
> Review request for KDE Frameworks, Plasma and Marco Martin.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> Add menu support to KDEPlatformSystemTrayIcon
>
> Uses new QPA API which got introduced in Qt 5.3.
>
> Provide an implementation for QPlatformSystemTrayIcon
>
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
>
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
>
> This is adressed in Qt 5.3 which extends the QPA API.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be
> src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c
> src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION
> src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION
> src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27
> src/platformtheme/kdeplatformtheme.cpp a5d86c27385447b7744cb8bca0cf65889872fb0b
>
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
>
>
> Testing
> -------
>
> Using systray from qtbase/examples/widgets/desktop/systray
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116075/">https://git.reviewboard.kde.org/r/116075/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a6c75f16514a2f8bb537f557bf8a07e957199171 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On March 5th, 2014, 11:14 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Marco Martin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 5, 2014, 11:14 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add menu support to KDEPlatformSystemTrayIcon
Uses new QPA API which got introduced in Qt 5.3.
Provide an implementation for QPlatformSystemTrayIcon
The idea is to force all QSystemTrayIcon to use our status notifiers
as we don't want to provide an xembed based system tray in the next
iteration of the Plasma desktop shell anymore.
The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
the system tray icon. Unfortunately a complete wrapping is not yet
possible as we cannot create a menu. We do not want to provide a
QPlatformMenu in our PlatformTheme and thus the menu used by
QSystemTrayIcon does not have a QPlatformMenu.
This is adressed in Qt 5.3 which extends the QPA API.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using systray from qtbase/examples/widgets/desktop/systray</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: \
grey">(fb58b3a0cb9acc062be0edeb53210048e364c1be)</span></li>
<li>src/platformtheme/CMakeLists.txt <span style="color: \
grey">(5fd949bee41b762120e120148de0b3b473de915c)</span></li>
<li>src/platformtheme/kdeplatformsystemtrayicon.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdeplatformsystemtrayicon.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdeplatformtheme.h <span style="color: \
grey">(f436eea4e3aa9cfda62654e5c6dc77aea05e8f27)</span></li>
<li>src/platformtheme/kdeplatformtheme.cpp <span style="color: \
grey">(a5d86c27385447b7744cb8bca0cf65889872fb0b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116075/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic