[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116460: Footer clock fix
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2014-02-28 4:59:06
Message-ID: 20140228045906.12300.21114 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116460/#review51289
-----------------------------------------------------------
However I am not sure why we have formatting logic in the application? Can't we use \
Qt.formatDateTime or others? @Shaan7 ?
mediaelements/mediawelcome/HomeScreenFooter.qml
<https://git.reviewboard.kde.org/r/116460/#comment36121>
Remove White space here and at other parts. For future if you are using Kate,
Set Settings > Configure Kate > Open/Save > Remove trailing spaces to on modified \
lines.
- Bhushan Shah
On Feb. 28, 2014, 2:42 a.m., Maulik Kotadia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116460/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 2:42 a.m.)
>
>
> Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of \
> 12:00 AM
>
> Diffs
> -----
>
> mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
>
> Diff: https://git.reviewboard.kde.org/r/116460/diff/
>
>
> Testing
> -------
>
> I've tested the diff and its working correctly
>
>
> Thanks,
>
> Maulik Kotadia
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116460/">https://git.reviewboard.kde.org/r/116460/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">However I am not sure \
why we have formatting logic in the application? Can't we use Qt.formatDateTime \
or others? @Shaan7 ?</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116460/diff/1/?file=250897#file250897line43" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/mediawelcome/HomeScreenFooter.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">43</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">43</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"><span class="tb"> </span><span class="tb"> </span></span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove \
White space here and at other parts. For future if you are using Kate,
Set Settings > Configure Kate > Open/Save > Remove trailing spaces to on \
modified lines.</pre> </div>
<br />
<p>- Bhushan Shah</p>
<br />
<p>On February 28th, 2014, 2:42 a.m. IST, Maulik Kotadia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny \
Kumari.</div> <div>By Maulik Kotadia.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 2:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM \
instead of 12:00 AM </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've tested the diff and its working correctly</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediawelcome/HomeScreenFooter.qml <span style="color: \
grey">(d2c0eb7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116460/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic