This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/ |
On February 26th, 2014, 5:43 p.m. UTC, Hrvoje Senjan wrote:
src/shell/CMakeLists.txt (Diff revision 2) 20 find_package(KF5TextEditor REQUIRED)This would mean: a) propagate KTextEditor to part of the KF5 releases (that was not the case with TP1 & alpha1) b) move the console or shell altogether to a different repo c) rewrite it without this frameworkOn February 26th, 2014, 5:58 p.m. UTC, Marco Martin wrote:
ah. is ok to depend from it from other projects? We tought about moving the whole shell subdirectory to kde-workspace, looks like we have to do it sooner.On February 26th, 2014, 6:14 p.m. UTC, Hrvoje Senjan wrote:
it 'can' depend atm - but alpha2 is scheduled for weekend =) (personally, i'd love to have KTextEditor there, but that's something for release & kate guys ;-)
since unfortunately it has been already merged, would be a branch (or just a tag) from before this branch was merged be ok for alpha2?
- Marco
On February 26th, 2014, 5:37 p.m. UTC, Marco Martin wrote:
Review request for Plasma.
By Marco Martin.
Updated Feb. 26, 2014, 5:37 p.m.
Repository:
plasma-framework
Description
Testing
Diffs
|