From kde-panel-devel Wed Feb 26 18:34:17 2014 From: "Marco Martin" Date: Wed, 26 Feb 2014 18:34:17 +0000 To: kde-panel-devel Subject: Re: Review Request 116085: welcome back the javascript interactive console Message-Id: <20140226183417.31571.63294 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139343967010131 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2130359223534763937==" --===============2130359223534763937== Content-Type: multipart/alternative; boundary="===============2774862141658355327==" --===============2774862141658355327== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the case with TP1 & alpha1) > > b) move the console or shell altogether to a different repo > > c) rewrite it without this framework > > Marco Martin wrote: > ah. > is ok to depend from it from other projects? > We tought about moving the whole shell subdirectory to kde-workspace, looks like we have to do it sooner. > > Hrvoje Senjan wrote: > it 'can' depend atm - but alpha2 is scheduled for weekend =) (personally, i'd love to have KTextEditor there, but that's something for release & kate guys ;-) since unfortunately it has been already merged, would be a branch (or just a tag) from before this branch was merged be ok for alpha2? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50965 ----------------------------------------------------------- On Feb. 26, 2014, 5:37 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116085/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 5:37 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this ports the js interactive console from plasma1 and ports it way from kde4support > > ui-wise it should look the same > > > Diffs > ----- > > src/shell/CMakeLists.txt db0e569 > src/shell/interactiveconsole.h PRE-CREATION > src/shell/interactiveconsole.cpp PRE-CREATION > src/shell/packages.h 999b4c9 > src/shell/packages.cpp 0b2aa3f > src/shell/scripting/layouttemplatepackagestructure.h abc5562 > src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca > src/shell/scripting/scriptengine.cpp 29735a0 > src/shell/shellcorona.cpp e84e0bf > src/shell/shellpluginloader.cpp c57b348 > > Diff: https://git.reviewboard.kde.org/r/116085/diff/ > > > Testing > ------- > > tried to add plasmoids from the console > > > Thanks, > > Marco Martin > > --===============2774862141658355327== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/

On February 26th, 2014, 5:43 p.m. UTC, Hrvoje Senjan wrote:

src/shell/CMakeLists.txt (Diff revision 2)
		20	find_package(KF5TextEditor REQUIRED)

This would mean:
a) propagate KTextEditor to part of the KF5 releases (that was not the case with TP1 & alpha1)
b) move the console or shell altogether to a different repo
c) rewrite it without this framework

On February 26th, 2014, 5:58 p.m. UTC, Marco Martin wrote:

ah.
is ok to depend from it from other projects?
We tought about moving the whole shell subdirectory to kde-workspace, looks like we have to do it sooner.

On February 26th, 2014, 6:14 p.m. UTC, Hrvoje Senjan wrote:

it 'can' depend atm - but alpha2 is scheduled for weekend =) (personally, i'd love to have KTextEditor there, but that's something for release & kate guys ;-)

since unfortunately it has been already merged,
would be a branch (or just a tag) from before this branch was merged be ok for alpha2?

- Marco

On February 26th, 2014, 5:37 p.m. UTC, Marco Martin wrote:

Review request for Plasma.

By Marco Martin.

Updated Feb. 26, 2014, 5:37 p.m.

Repository: plasma-framework

Description

this ports the js interactive console from plasma1 and ports it way from kde4support

ui-wise it should look the same

Testing

tried to add plasmoids from the console

Diffs

src/shell/CMakeLists.txt (db0e569)
src/shell/interactiveconsole.h (PRE-CREATION)
src/shell/interactiveconsole.cpp (PRE-CREATION)
src/shell/packages.h (999b4c9)
src/shell/packages.cpp (0b2aa3f)
src/shell/scripting/layouttemplatepackagestructure.h (abc5562)
src/shell/scripting/layouttemplatepackagestructure.cpp (bc1d0ca)
src/shell/scripting/scriptengine.cpp (29735a0)
src/shell/shellcorona.cpp (e84e0bf)
src/shell/shellpluginloader.cpp (c57b348)

--===============2774862141658355327==-- --===============2130359223534763937== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2130359223534763937==--