'Re: Review Request 116085: welcome back the javascript interactive console'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116085: welcome back the javascript interactive console
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-02-26 17:11:57
Message-ID: 20140226171157.31571.8927 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50960
-----------------------------------------------------------

Ship it!

Ship It!

- David Edmundson

On Feb. 26, 2014, 4:03 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 4:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports the js interactive console from plasma1 and ports it way from kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -----
> 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> -------
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116085/">https://git.reviewboard.kde.org/r/116085/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On February 26th, 2014, 4:03 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2014, 4:03 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this ports the js interactive console from plasma1 and ports it way from \
kde4support

ui-wise it should look the same</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tried to add plasmoids from the console</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/shell/CMakeLists.txt <span style="color: grey">(db0e569)</span></li>

 <li>src/shell/interactiveconsole.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/shell/interactiveconsole.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/shell/packages.h <span style="color: grey">(999b4c9)</span></li>

 <li>src/shell/packages.cpp <span style="color: grey">(0b2aa3f)</span></li>

 <li>src/shell/scripting/layouttemplatepackagestructure.h <span style="color: \
grey">(abc5562)</span></li>

 <li>src/shell/scripting/layouttemplatepackagestructure.cpp <span style="color: \
grey">(bc1d0ca)</span></li>

 <li>src/shell/scripting/scriptengine.cpp <span style="color: \
grey">(29735a0)</span></li>

 <li>src/shell/shellcorona.cpp <span style="color: grey">(e84e0bf)</span></li>

 <li>src/shell/shellpluginloader.cpp <span style="color: grey">(c57b348)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116085/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 