--===============2439511335173585052== Content-Type: multipart/alternative; boundary="===============8544080869121976261==" --===============8544080869121976261== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/ ----------------------------------------------------------- (Updated Feb. 26, 2014, 4:07 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Sinny Kumari and Sujith Haridasan. Repository: plasma-mediacenter Description ------- We have lots of issues because of the fact that the playlist model is not aware of what is playing right now and what is current index for the ListView. Additionally logic was thrown here and there in C++ and QML. This patch makes the model aware of the conect of currently playing index and it also makes sure that the model is in control of what is playing and how to play next/previous. This patch should not break any existing functionality except that changing playlist will make the current media to stop. This is to have consistency in what is playing and what the model can deduce it is playing. This will be improved in an upcoming patch but other things should keep working. Diffs ----- libs/mediacenter/playlistmodel.cpp 9c1dea9 mediaelements/playlist/MultiplePlaylists.qml d94fe6e mediaelements/playlist/Playlist.qml fd83c21 mediaelements/playlist/PlaylistDelegate.qml e1bd31d shells/newshell/application.cpp adc95dc shells/newshell/mainwindow.h d918e3d shells/newshell/mainwindow.cpp 7f7f31d shells/newshell/package/contents/ui/mediacenter.qml b6cb87c libs/mediacenter/multipleplaylistmodel.h 06b64df libs/mediacenter/multipleplaylistmodel.cpp f2c9246 libs/mediacenter/playlistmodel.h f79f814 Diff: https://git.reviewboard.kde.org/r/115764/diff/ Testing ------- Tested with usual playback and with passing multiple files as command line parameters. Thanks, Shantanu Tushar --===============8544080869121976261== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/

This change has been marked as submitted.

Review request for Plasma, Sinny Kumari and Sujith Haridasan.
By Shantanu Tushar.

Updated Feb. 26, 2014, 4:07 p.m.

Repository: plasma-mediacenter

Description 

We have lots of issues because of the fact that the playlist model is not aware of what is playing right now and what is current index for the ListView. Additionally logic was thrown here and there in C++ and QML. This patch makes the model aware of the conect of currently playing index and it also makes sure that the model is in control of what is playing and how to play next/previous.

This patch should not break any existing functionality except that changing playlist will make the current media to stop. This is to have consistency in what is playing and what the model can deduce it is playing. This will be improved in an upcoming patch but other things should keep working.

Testing 

Tested with usual playback and with passing multiple files as command line parameters.

Diffs

  • libs/mediacenter/playlistmodel.cpp (9c1dea9)
  • mediaelements/playlist/MultiplePlaylists.qml (d94fe6e)
  • mediaelements/playlist/Playlist.qml (fd83c21)
  • mediaelements/playlist/PlaylistDelegate.qml (e1bd31d)
  • shells/newshell/application.cpp (adc95dc)
  • shells/newshell/mainwindow.h (d918e3d)
  • shells/newshell/mainwindow.cpp (7f7f31d)
  • shells/newshell/package/contents/ui/mediacenter.qml (b6cb87c)
  • libs/mediacenter/multipleplaylistmodel.h (06b64df)
  • libs/mediacenter/multipleplaylistmodel.cpp (f2c9246)
  • libs/mediacenter/playlistmodel.h (f79f814)

View Diff
--===============8544080869121976261==-- --===============2439511335173585052== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2439511335173585052==--