[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previo
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2014-02-26 15:30:04
Message-ID: 20140226153004.18188.25293 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 26, 2014, 2:52 p.m., Shantanu Tushar wrote:
> > I see a weird behavior with this patch, if you follow these steps-
> > 1. Open PMC, select "All Videos"
> > 2. Press backspace to go back to home screen
> > 3. Press enter to go to "All Videos" again
> >
> > This leads to a blank browser without anything in it. Can you verify this and \
> > fix?
>
> Harshit Agarwal wrote:
> I seem to be unable to reproduce the error. On doing the exact same steps, it goes \
> to the 'All Videos' window, and shows the videos listed there, with default focus \
> at the search bar. To use the backspace functionality again, one would have to \
> press the down arrow key once, in order to lose focus on the search bar and gain \
> focus on the videos over there, then the backspace would work to go back to the \
> previous window.
> Can you explain on the problem bit more so that it can be reproduced?
>
> However I noticed a thing, when PMC is opened for the first time, and 'All Videos' \
> is selected, it takes around 2 seconds to load the videos with their thumbnails. \
> Probably this is the time taken for it to read the folder, and then display the \
> content. Or any anomaly here?
Hmm then it might just be because of something else I'm working on. I'll wait for \
someone else to try this out.
- Shantanu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116063/#review50939
-----------------------------------------------------------
On Feb. 26, 2014, 7:45 a.m., Harshit Agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116063/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2014, 7:45 a.m.)
>
>
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith \
> Haridasan.
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Through this patch, the user can go to the previous window through the backspace \
> key also. The issue with the focus on the Search Bar has been solved. The backspace \
> option works only when the search bar is not in focus.
>
> Diffs
> -----
>
> shells/newshell/package/contents/ui/mediacenter.qml 49ea403
>
> Diff: https://git.reviewboard.kde.org/r/116063/diff/
>
>
> Testing
> -------
>
> It has been tested.
>
>
> Thanks,
>
> Harshit Agarwal
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116063/">https://git.reviewboard.kde.org/r/116063/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 26th, 2014, 2:52 p.m. UTC, <b>Shantanu \
Tushar</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I see a weird behavior with this patch, if you follow these steps- 1. \
Open PMC, select "All Videos" 2. Press backspace to go back to home screen
3. Press enter to go to "All Videos" again
This leads to a blank browser without anything in it. Can you verify this and \
fix?</pre> </blockquote>
<p>On February 26th, 2014, 3:24 p.m. UTC, <b>Harshit Agarwal</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I seem to be unable to \
reproduce the error. On doing the exact same steps, it goes to the 'All \
Videos' window, and shows the videos listed there, with default focus at the \
search bar. To use the backspace functionality again, one would have to press the \
down arrow key once, in order to lose focus on the search bar and gain focus on the \
videos over there, then the backspace would work to go back to the previous window.
Can you explain on the problem bit more so that it can be reproduced?
However I noticed a thing, when PMC is opened for the first time, and 'All \
Videos' is selected, it takes around 2 seconds to load the videos with their \
thumbnails. Probably this is the time taken for it to read the folder, and then \
display the content. Or any anomaly here?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm then it might just \
be because of something else I'm working on. I'll wait for someone else to \
try this out.</pre> <br />
<p>- Shantanu</p>
<br />
<p>On February 26th, 2014, 7:45 a.m. UTC, Harshit Agarwal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and \
Sujith Haridasan.</div> <div>By Harshit Agarwal.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2014, 7:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Through this patch, the user can go to the previous window through the \
backspace key also. The issue with the focus on the Search Bar has been solved. The \
backspace option works only when the search bar is not in focus.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It has been tested.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(49ea403)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116063/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic