From kde-panel-devel Wed Feb 26 11:57:42 2014 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Wed, 26 Feb 2014 11:57:42 +0000 To: kde-panel-devel Subject: Re: Review Request 115910: Screenedge show support for Clients Message-Id: <20140226115742.18188.34145 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139341589508793 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5407013718995494323==" --===============5407013718995494323== Content-Type: multipart/alternative; boundary="===============4350057203721158703==" --===============4350057203721158703== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/ ----------------------------------------------------------- (Updated Feb. 26, 2014, 11:57 a.m.) Status ------ This change has been marked as submitted. Review request for kwin and Plasma. Repository: kde-workspace Description ------- Screenedge show support for Clients This provides a new protocol intended to be used by auto-hiding panels to make use of the centralized screen edges. To use it a Client can set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin. As value it takes: * 0: top edge * 1: right edge * 2: bottom edge * 3: left edge KWin will hide the Client (hide because unmap or minimize would break it) and create an Edge. If that Edge gets triggered the Client is shown again and the property gets deleted. If the Client doesn't border the specified screen edge the Client gets shown immediately so that we never end in a situation that we cannot unhide the auto-hidden panel again. The exact process is described in the documentation of ScreenEdges. The Client can request to be shown again by deleting the property. If KWin gets restarted the state is read from the property and it is tried to create the edge as described. As this is a KWin specific extension we need to discuss what it means for Clients using this feature with other WMs: it does nothing. As the Client gets hidden by KWin and not by the Client, it just doesn't get hidden if the WM doesn't provide the feature. In case of an auto-hiding panel this seems like a good solution given that we don't want to hide it if we cannot unhide it. Of course there's the option for the Client to provide that feature itself and if that's wanted we would need to announce the feature in the _NET_SUPPORTED atom. At the moment that doesn't sound like being needed as Plasma doesn't want to provide an own implementation. The implementation comes with a small test application showing how the feature is intended to be used. Diffs ----- kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d kwin/client.h 6a0dbe4f45f9bb6c58de8c045488cec990e95118 kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366 kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18 kwin/manage.cpp 3e385cd6aeceee3c3bff4e09be2aee130856201f kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31 kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14 kwin/tests/screenedgeshowtest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115910/diff/ Testing ------- Thanks, Martin Gräßlin --===============4350057203721158703== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/

This change has been marked as submitted.

Review request for kwin and Plasma.
By Martin Gräßlin.

Updated Feb. 26, 2014, 11:57 a.m.

Repository: kde-workspace

Description 

Screenedge show support for Clients

This provides a new protocol intended to be used by auto-hiding panels
to make use of the centralized screen edges. To use it a Client can
set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
As value it takes:
* 0: top edge
* 1: right edge
* 2: bottom edge
* 3: left edge

KWin will hide the Client (hide because unmap or minimize would break
it) and create an Edge. If that Edge gets triggered the Client is shown
again and the property gets deleted. If the Client doesn't border the
specified screen edge the Client gets shown immediately so that we
never end in a situation that we cannot unhide the auto-hidden panel
again. The exact process is described in the documentation of
ScreenEdges. The Client can request to be shown again by deleting the
property.

If KWin gets restarted the state is read from the property and it is
tried to create the edge as described.

As this is a KWin specific extension we need to discuss what it means
for Clients using this feature with other WMs: it does nothing. As
the Client gets hidden by KWin and not by the Client, it just doesn't
get hidden if the WM doesn't provide the feature. In case of an
auto-hiding panel this seems like a good solution given that we don't
want to hide it if we cannot unhide it. Of course there's the option
for the Client to provide that feature itself and if that's wanted we
would need to announce the feature in the _NET_SUPPORTED atom. At the
moment that doesn't sound like being needed as Plasma doesn't want to
provide an own implementation.

The implementation comes with a small test application showing how
the feature is intended to be used.

Diffs

  • kwin/atoms.h (1690067c5d1da59f38f9e77ef64eacfbc1faa0cf)
  • kwin/atoms.cpp (904f5efe4a32e3673dae9e6da92bf4336def660d)
  • kwin/client.h (6a0dbe4f45f9bb6c58de8c045488cec990e95118)
  • kwin/client.cpp (36431bfc33418a207de12fa8cc95a35539256366)
  • kwin/events.cpp (1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18)
  • kwin/manage.cpp (3e385cd6aeceee3c3bff4e09be2aee130856201f)
  • kwin/screenedge.h (60f5fd669ccc5eb627feffa460552558d1765b31)
  • kwin/screenedge.cpp (04cf0d6d5262ab84d88559b6dc85e099efec77bf)
  • kwin/tests/CMakeLists.txt (3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14)
  • kwin/tests/screenedgeshowtest.cpp (PRE-CREATION)

View Diff
--===============4350057203721158703==-- --===============5407013718995494323== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5407013718995494323==--