From kde-panel-devel Wed Feb 26 09:45:49 2014 From: "Marco Martin" Date: Wed, 26 Feb 2014 09:45:49 +0000 To: kde-panel-devel Subject: Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon Message-Id: <20140226094549.11047.98441 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139340797806287 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1338939426459927587==" --===============1338939426459927587== Content-Type: multipart/alternative; boundary="===============8544033690467841187==" --===============8544033690467841187== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50911 ----------------------------------------------------------- +1 from me - Marco Martin On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116075/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 8:09 a.m.) > > > Review request for KDE Frameworks, Plasma and Marco Martin. > > > Repository: frameworkintegration > > > Description > ------- > > Add menu support to KDEPlatformSystemTrayIcon > > Uses new QPA API which got introduced in Qt 5.3. > > Provide an implementation for QPlatformSystemTrayIcon > > The idea is to force all QSystemTrayIcon to use our status notifiers > as we don't want to provide an xembed based system tray in the next > iteration of the Plasma desktop shell anymore. > > The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement > the system tray icon. Unfortunately a complete wrapping is not yet > possible as we cannot create a menu. We do not want to provide a > QPlatformMenu in our PlatformTheme and thus the menu used by > QSystemTrayIcon does not have a QPlatformMenu. > > This is adressed in Qt 5.3 which extends the QPA API. > > > Diffs > ----- > > autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be > src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c > src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION > src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION > src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 > src/platformtheme/kdeplatformtheme.cpp a5d86c27385447b7744cb8bca0cf65889872fb0b > > Diff: https://git.reviewboard.kde.org/r/116075/diff/ > > > Testing > ------- > > Using systray from qtbase/examples/widgets/desktop/systray > > > Thanks, > > Martin Gräßlin > > --===============8544033690467841187== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ 

+1 from me

- Marco Martin


On February 26th, 2014, 8:09 a.m. UTC, Martin Gräßlin wrote:

Review request for KDE Frameworks, Plasma and Marco Martin.
By Martin Gräßlin.

Updated Feb. 26, 2014, 8:09 a.m.

Repository: frameworkintegration

Description 

Add menu support to KDEPlatformSystemTrayIcon

Uses new QPA API which got introduced in Qt 5.3.

Provide an implementation for QPlatformSystemTrayIcon

The idea is to force all QSystemTrayIcon to use our status notifiers
as we don't want to provide an xembed based system tray in the next
iteration of the Plasma desktop shell anymore.

The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
the system tray icon. Unfortunately a complete wrapping is not yet
possible as we cannot create a menu. We do not want to provide a
QPlatformMenu in our PlatformTheme and thus the menu used by
QSystemTrayIcon does not have a QPlatformMenu.

This is adressed in Qt 5.3 which extends the QPA API.

Testing 

Using systray from qtbase/examples/widgets/desktop/systray

Diffs

  • autotests/CMakeLists.txt (fb58b3a0cb9acc062be0edeb53210048e364c1be)
  • src/platformtheme/CMakeLists.txt (5fd949bee41b762120e120148de0b3b473de915c)
  • src/platformtheme/kdeplatformsystemtrayicon.h (PRE-CREATION)
  • src/platformtheme/kdeplatformsystemtrayicon.cpp (PRE-CREATION)
  • src/platformtheme/kdeplatformtheme.h (f436eea4e3aa9cfda62654e5c6dc77aea05e8f27)
  • src/platformtheme/kdeplatformtheme.cpp (a5d86c27385447b7744cb8bca0cf65889872fb0b)

View Diff
--===============8544033690467841187==-- --===============1338939426459927587== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1338939426459927587==--