[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116032: The MediaWindow was stopping on the last frame after the media finished p
From: "Harshit Agarwal" <see.harshit () gmail ! com>
Date: 2014-02-25 17:55:10
Message-ID: 20140225175510.11047.72020 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116032/
-----------------------------------------------------------
(Updated Feb. 25, 2014, 5:55 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.
Repository: plasma-mediacenter
Description
-------
The media window was stopping on the last frame of the video whenever a video was \
played from the local drive. Ideally it should go back to the last video listing \
window at the completion of the video-play. This has been implemented now.
Diffs
-----
shells/newshell/package/contents/ui/mediacenter.qml b6cb87c
Diff: https://git.reviewboard.kde.org/r/116032/diff/
Testing
-------
It has been tested on multiple machines, and through commandline also.
Thanks,
Harshit Agarwal
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116032/">https://git.reviewboard.kde.org/r/116032/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and \
Sujith Haridasan.</div> <div>By Harshit Agarwal.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2014, 5:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The media window was stopping on the last frame of the video whenever a \
video was played from the local drive. Ideally it should go back to the last video \
listing window at the completion of the video-play. This has been implemented \
now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It has been tested on multiple machines, and through commandline \
also.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(b6cb87c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116032/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic