'Re: Review Request 116032: The MediaWindow was stopping on the last frame after the media finished p'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116032: The MediaWindow was stopping on the last frame after the media finished p
From:       Harshit Agarwal <see.harshit () gmail ! com>
Date:       2014-02-25 17:55:03
Message-ID: CAAmPk1crm7bsXyLebtFttQR7JtrPNcFJeccumCwzV-DeN+HCLA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

No I do not posses a KDE Developer account. Would you please commit the
changes?

Regards,
Harshit Agarwal.
3rd Year,
Computer Science and Engineering,
National Institute of Technology, Durgapur.
Ph. No.: +91-8942031165

On Tue, Feb 25, 2014 at 11:09 PM, Sinny Kumari <ksinny@gmail.com> wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116032/
> 
> Ship it!
> 
> Nice work and good start Harshit!
> 
> If you don't have KDE developer account, I will commit changes on behalf of you :)
> 
> 
> - Sinny Kumari
> 
> On February 24th, 2014, 10:29 p.m. UTC, Harshit Agarwal wrote:
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari,
> and Sujith Haridasan.
> By Harshit Agarwal.
> 
> *Updated Feb. 24, 2014, 10:29 p.m.*
> *Repository: * plasma-mediacenter
> Description
> 
> The media window was stopping on the last frame of the video whenever a video was \
> played from the local drive. Ideally it should go back to the last video listing \
> window at the completion of the video-play. This has been implemented now. 
> Testing
> 
> It has been tested on multiple machines, and through commandline also.
> 
> Diffs
> 
> - shells/newshell/package/contents/ui/mediacenter.qml (b6cb87c)
> 
> View Diff <https://git.reviewboard.kde.org/r/116032/diff/>
> 

[Attachment #5 (text/html)]

<div dir="ltr">No I do not posses a KDE Developer account. Would you please commit \
the changes?<br></div><div class="gmail_extra"><br clear="all"><div><div \
dir="ltr"><div dir="ltr"><div>Regards,</div>Harshit Agarwal.<div>3rd Year,</div> \
<div>Computer Science and Engineering,</div><div>National Institute of Technology, \
Durgapur.</div><div>Ph. No.: +91-8942031165</div></div></div></div> <br><br><div \
class="gmail_quote">On Tue, Feb 25, 2014 at 11:09 PM, Sinny Kumari <span \
dir="ltr">&lt;<a href="mailto:ksinny@gmail.com" \
target="_blank">ksinny@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="">
   <table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" \
width="100%">  <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116032/" \
target="_blank">https://git.reviewboard.kde.org/r/116032/</a>  </td>
    </tr>
   </tbody></table>
   <br>

 </div><p>Ship it!</p>

 <pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Nice \
work and good start Harshit!

If you don&#39;t have KDE developer account, I will commit changes on behalf of you \
:)</pre>  <br>

<p>- Sinny Kumari</p><div class="">

<br>
<p>On February 24th, 2014, 10:29 p.m. UTC, Harshit Agarwal wrote:</p>

</div><table style="background-image:url(&#39;https://git.reviewboard.kde.org/static/r \
b/images/review_request_box_top_bg.ab6f3b1072c9.png&#39;);background-repeat:repeat-x;border:1px \
black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">

 <tbody><tr>
  <td><div class="">

<div>Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and \
Sujith Haridasan.</div> <div>By Harshit Agarwal.</div>

<p style="color:grey"><i>Updated Feb. 24, 2014, 10:29 p.m.</i></p>

<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">The \
media window was stopping on the last frame of the video whenever a video was played \
from the local drive. Ideally it should go back to the last video listing window at \
the completion of the video-play. This has been implemented now.</pre>

  </td>
 </tr>
</tbody></table>

<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
</div><table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">It \
has been tested on multiple machines, and through commandline also.</pre>

  </td>
 </tr>
</tbody></table><div class="">

<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>shells/newshell/package/contents/ui/mediacenter.qml <span \
style="color:grey">(b6cb87c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116032/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>

  </div></td>
 </tr>
</tbody></table>

  </div>
 </div>

</blockquote></div><br></div>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 