'Review Request 115989: [kinfocenter] Add new module for a Wayland Compositor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 115989: [kinfocenter] Add new module for a Wayland Compositor
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-02-24 8:13:17
Message-ID: 20140224081317.25983.91074 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115989/
-----------------------------------------------------------

Review request for Plasma and David Stephen Hubner.

Repository: kde-workspace

Description
-------

[kinfocenter] Add new module for a Wayland Compositor

Inspired by the module for X-Server we have a new module for Wayland
Compositors. The module introduces a new optional build dependency to
wayland client libraries.

Just like the X-Server module it talks to Wayland directly without the
help of Qt. It connects to the registry and adds all reported
interfaces to the tree widget. For outputs and seats it registers a
listener to also include this information. For every output the
information is appended, for a seat the capabilities are included.

This approach should allow to add information about further interfaces
if they provide interesting information in future.

Diffs
-----

  kinfocenter/Modules/base/CMakeLists.txt \
5e05617fc8e6fbb174c33e81a62264311da8c040   \
kinfocenter/Modules/base/config-infocenter.h.cmake \
abde2c5e8a5400cf1939ddd0cce1e1fff96acb9e   \
kinfocenter/Modules/base/info_linux.cpp \
3ca95c15a1d87245df118ffaea935d88200b3327   \
kinfocenter/Modules/base/info_wayland.h PRE-CREATION   \
kinfocenter/Modules/base/info_wayland.cpp PRE-CREATION   \
kinfocenter/Modules/base/os_current.h \
b1c262f7f602bd6284ec6299e2b33cc0a056a41d   \
kinfocenter/Modules/info/CMakeLists.txt \
211c0cd17dd0b723eadc1cc0b1efdb24968355ba   \
kinfocenter/Modules/info/main.cpp c07594c60e869d9d79b4ebb05a9d8a15389a15e5  \
kinfocenter/Modules/info/wayland.desktop PRE-CREATION   \
kinfocenter/Modules/pci/CMakeLists.txt \
03382625fa77b67639029867f534728fcddf61e8 

Diff: https://git.reviewboard.kde.org/r/115989/diff/

Testing
-------

Run against Weston and also with no Weston running.

File Attachments
----------------

Module in action
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/24/1a9c6709-4220-499b-962b-f43894800d7b__kinfocenter-wayland-module.png

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115989/">https://git.reviewboard.kde.org/r/115989/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for Plasma and David Stephen Hubner.</div>
<div>By Martin Gräßlin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[kinfocenter] Add new module for a Wayland Compositor

Inspired by the module for X-Server we have a new module for Wayland
Compositors. The module introduces a new optional build dependency to
wayland client libraries.

Just like the X-Server module it talks to Wayland directly without the
help of Qt. It connects to the registry and adds all reported
interfaces to the tree widget. For outputs and seats it registers a
listener to also include this information. For every output the
information is appended, for a seat the capabilities are included.

This approach should allow to add information about further interfaces
if they provide interesting information in future.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Run against Weston and also with no Weston running.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kinfocenter/Modules/base/CMakeLists.txt <span style="color: \
grey">(5e05617fc8e6fbb174c33e81a62264311da8c040)</span></li>

 <li>kinfocenter/Modules/base/config-infocenter.h.cmake <span style="color: \
grey">(abde2c5e8a5400cf1939ddd0cce1e1fff96acb9e)</span></li>

 <li>kinfocenter/Modules/base/info_linux.cpp <span style="color: \
grey">(3ca95c15a1d87245df118ffaea935d88200b3327)</span></li>

 <li>kinfocenter/Modules/base/info_wayland.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kinfocenter/Modules/base/info_wayland.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kinfocenter/Modules/base/os_current.h <span style="color: \
grey">(b1c262f7f602bd6284ec6299e2b33cc0a056a41d)</span></li>

 <li>kinfocenter/Modules/info/CMakeLists.txt <span style="color: \
grey">(211c0cd17dd0b723eadc1cc0b1efdb24968355ba)</span></li>

 <li>kinfocenter/Modules/info/main.cpp <span style="color: \
grey">(c07594c60e869d9d79b4ebb05a9d8a15389a15e5)</span></li>

 <li>kinfocenter/Modules/info/wayland.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kinfocenter/Modules/pci/CMakeLists.txt <span style="color: \
grey">(03382625fa77b67639029867f534728fcddf61e8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115989/diff/" \
style="margin-left: 3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File \
Attachments </h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/24/1a9c6709-4220-499b-962b-f43894800d7b__kinfocenter-wayland-module.png">Module \
in action</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 