'Re: Review Request 114260: Port mouse dataengine'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114260: Port mouse dataengine
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2014-02-21 12:59:31
Message-ID: 20140221125931.27041.61487 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114260/#review50470
-----------------------------------------------------------

Ship it!

Removing the scheduleSourcesUpdated calls is fine. Thanks for cleaning this up!

- Sebastian Kügler

On Feb. 21, 2014, 6:54 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114260/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 6:54 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> = subject.
> 
> I commented the lines about scheduleSourcesUpdated(). What to do with them?
> 
> 
> Diffs
> -----
> 
> plasma/generic/dataengines/mouse/mouseengine.cpp \
> 19a7fb7405647963ebadb4f71104e8164b729df7  \
> plasma/generic/dataengines/mouse/mouseengine.h \
> d55565dc3875b794dce14054d9a8b77cef9b2347  \
> plasma/generic/dataengines/mouse/cursornotificationhandler.cpp \
> 3cb9add2ec1d4cb4d5904a381b8ba8f29279e05b  plasma/generic/dataengines/CMakeLists.txt \
> 5e9f11bcef806576946257bdeaa40efb445b7daf  \
> plasma/generic/dataengines/mouse/CMakeLists.txt \
> 29cab878bd1fb514d7ac025134fbfb58a5a1376e  \
> plasma/generic/dataengines/mouse/cursornotificationhandler.h \
> 3b571f8f5ffe6db4efeef7827acf003911bcd5dc  
> Diff: https://git.reviewboard.kde.org/r/114260/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114260/">https://git.reviewboard.kde.org/r/114260/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removing the \
scheduleSourcesUpdated calls is fine. Thanks for cleaning this up!</pre>  <br />

<p>- Sebastian Kügler</p>

<br />
<p>On February 21st, 2014, 6:54 a.m. UTC, Andrea Scarpino wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Andrea Scarpino.</div>

<p style="color: grey;"><i>Updated Feb. 21, 2014, 6:54 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">= subject.

I commented the lines about scheduleSourcesUpdated(). What to do with them?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/dataengines/mouse/mouseengine.cpp <span style="color: \
grey">(19a7fb7405647963ebadb4f71104e8164b729df7)</span></li>

 <li>plasma/generic/dataengines/mouse/mouseengine.h <span style="color: \
grey">(d55565dc3875b794dce14054d9a8b77cef9b2347)</span></li>

 <li>plasma/generic/dataengines/mouse/cursornotificationhandler.cpp <span \
style="color: grey">(3cb9add2ec1d4cb4d5904a381b8ba8f29279e05b)</span></li>

 <li>plasma/generic/dataengines/CMakeLists.txt <span style="color: \
grey">(5e9f11bcef806576946257bdeaa40efb445b7daf)</span></li>

 <li>plasma/generic/dataengines/mouse/CMakeLists.txt <span style="color: \
grey">(29cab878bd1fb514d7ac025134fbfb58a5a1376e)</span></li>

 <li>plasma/generic/dataengines/mouse/cursornotificationhandler.h <span style="color: \
grey">(3b571f8f5ffe6db4efeef7827acf003911bcd5dc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114260/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 