'Review Request 115922: Drop taskbar thumbnail effect'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 115922: Drop taskbar thumbnail effect
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-02-20 18:14:25
Message-ID: 20140220181425.1865.72648 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115922/
-----------------------------------------------------------

Review request for kwin and Plasma.

Repository: kde-workspace

Description
-------

Drop taskbar thumbnail effect

As Plasma components provide a thumbnail which does not use the
effect we can also remove it.

Diffs
-----

  kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop b26d7a3e4c80ee39ab200fdd53e0890d68d7d450 
  kwin/effects/taskbarthumbnail/taskbarthumbnail.h e5cb235c9b75a2575b286c56131fbceb1f136112 
  kwin/effects/CMakeLists.txt de85ad6e5dbd3c1080c0fb9319338ce756b46264 
  kwin/effects/effect_builtins.cpp eb82204586aa9dde16f8bf57f8aa1b348dcb607b 
  kwin/effects/taskbarthumbnail/CMakeLists.txt c502753907fc12a5dc8c393af466572ea03988fd 
  kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp 4f7dce7fb4af89c103cbf6dc7edee47dee34238e 

Diff: https://git.reviewboard.kde.org/r/115922/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115922/">https://git.reviewboard.kde.org/r/115922/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Drop taskbar thumbnail effect

As Plasma components provide a thumbnail which does not use the
effect we can also remove it.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop <span style="color: \
grey">(b26d7a3e4c80ee39ab200fdd53e0890d68d7d450)</span></li>

 <li>kwin/effects/taskbarthumbnail/taskbarthumbnail.h <span style="color: \
grey">(e5cb235c9b75a2575b286c56131fbceb1f136112)</span></li>

 <li>kwin/effects/CMakeLists.txt <span style="color: \
grey">(de85ad6e5dbd3c1080c0fb9319338ce756b46264)</span></li>

 <li>kwin/effects/effect_builtins.cpp <span style="color: \
grey">(eb82204586aa9dde16f8bf57f8aa1b348dcb607b)</span></li>

 <li>kwin/effects/taskbarthumbnail/CMakeLists.txt <span style="color: \
grey">(c502753907fc12a5dc8c393af466572ea03988fd)</span></li>

 <li>kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp <span style="color: \
grey">(4f7dce7fb4af89c103cbf6dc7edee47dee34238e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115922/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 