[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2014-02-20 16:38:59
Message-ID: 20140220163859.1865.97936 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114493/#review50384
-----------------------------------------------------------
Ship it!
I've found a few more smallish problems. Please address those, and then feel free to merge it.
plasmoidviewer/CMakeLists.txt
<https://git.reviewboard.kde.org/r/114493/#comment35435>
org.kde.plasma.plasmoidviewer (we put everything under org.kde.plasma)
plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
<https://git.reviewboard.kde.org/r/114493/#comment35438>
Should be BottomEdge, not Bottomedge
plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
<https://git.reviewboard.kde.org/r/114493/#comment35437>
there's a trailing t at the end which doesn't belong here.
plasmoidviewer/view.cpp
<https://git.reviewboard.kde.org/r/114493/#comment35439>
i18n (we do it for other console output as well)
plasmoidviewer/view.cpp
<https://git.reviewboard.kde.org/r/114493/#comment35440>
i18n (we do it for other console output as well)
- Sebastian Kügler
On Feb. 20, 2014, 4:19 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114493/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 4:19 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasmate
>
>
> Description
> -------
>
> This is a merge request for plasmoidviewer2 branch into the frameworks branch.
>
> Plasmoidviewer2 branch contains some missing features and bug fixes.
>
>
> Diffs
> -----
>
> plasmoidviewer/qmlpackages/containment/contents/ui/main.qml 6558710
> plasmoidviewer/qmlpackages/containment/metadata.desktop 9ddd217
> plasmoidviewer/qmlpackages/shell/contents/views/Background.qml PRE-CREATION
> plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml e5bedf3
> plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml PRE-CREATION
> plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml PRE-CREATION
> plasmoidviewer/view.h 4cc472b
> plasmoidviewer/view.cpp 511fe66
> plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml b23e098
> plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml 33d72c0
> plasmoidviewer/CMakeLists.txt 30de8e2
> plasmoidviewer/fullview.h 7d4c70d
> plasmoidviewer/fullview.cpp 898931a
> plasmoidviewer/main.cpp 9b41e78
> plasmoidviewer/qmlpackages/containment/Messages.sh c8a9b60
> plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js 62e149a
> plasmoidviewer/qmlpackages/containment/contents/config/main.xml d889999
>
> Diff: https://git.reviewboard.kde.org/r/114493/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114493/">https://git.reviewboard.kde.org/r/114493/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've found a few \
more smallish problems. Please address those, and then feel free to merge it.</pre> \
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114493/diff/5-6/?file=243428#file243428line21" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">21</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">plasma_install_package</span><span class="p">(</span><span \
class="s">qmlpackages/shell</span> <span class="s">org.<span \
class="hl">kde</span>.plasmoidviewershell</span> <span class="s">plasma/shells</span> \
<span class="s">shell</span><span class="p">)</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">21</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">plasma_install_package</span><span class="p">(</span><span \
class="s">qmlpackages/shell</span> <span class="s">org.<span \
class="hl">plasma</span>.plasmoidviewershell</span> <span \
class="s">plasma/shells</span> <span class="s">shell</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">org.kde.plasma.plasmoidviewer (we put everything under \
org.kde.plasma)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114493/diff/5-6/?file=243442#file243442line121" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml</a> <span \
style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">121</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">onClicked:</span> <span class="nx">location</span><span \
class="p">(</span><span class="nx">PlasmaCore</span><span class="p">.</span><span \
class="nx">Types</span><span class="p">.</span><span \
class="nx">Bottomedge</span><span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">121</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">onClicked:</span> <span class="nx">location</span><span \
class="p">(</span><span class="nx">PlasmaCore</span><span class="p">.</span><span \
class="nx">Types</span><span class="p">.</span><span \
class="nx">Bottomedge</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should be \
BottomEdge, not Bottomedge</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114493/diff/5-6/?file=243442#file243442line128" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml</a> <span \
style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">128</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">text:</span> <span class="nx">i18n</span><span class="p">(</span><span \
class="s2">"Right<span class="hl">e</span>dget"</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">128</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">text:</span> \
<span class="nx">i18n</span><span class="p">(</span><span class="s2">"Right<span \
class="hl"> E</span>dget"</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there's \
a trailing t at the end which doesn't belong here.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114493/diff/5-6/?file=243444#file243444line57" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.cpp</a> <span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
View::addApplet(const QString &applet)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">57</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qCritical</span><span class="p">(</span><span class="s">"Applet \
doesn't exist!"</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">57</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qCritical</span><span class="p">(</span><span class="s">"Applet <span \
class="hl">%s </span>doesn't exist!"</span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="n"><span \
class="hl">qPrintable</span></span><span class="p"><span \
class="hl">(</span></span><span class="n"><span class="hl">applet</span></span><span \
class="p"><span class="hl">)</span>);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i18n (we do \
it for other console output as well)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114493/diff/5-6/?file=243444#file243444line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoidviewer/view.cpp</a> <span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
View::addApplet(const QString &applet)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">68</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qCritical</span><span class="p">(</span><span class="s">"Containment \
doesn't exist"</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qCritical</span><span class="p">(</span><span class="s">"Containment \
<span class="hl">%s </span>doesn't exist"</span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="n"><span \
class="hl">qPrintable</span></span><span class="p"><span \
class="hl">(</span></span><span class="n"><span class="hl">cont</span></span><span \
class="p"><span class="hl">)</span>);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i18n (we do \
it for other console output as well)</pre> </div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 20th, 2014, 4:19 p.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 4:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a merge request for plasmoidviewer2 branch into the frameworks \
branch.
Plasmoidviewer2 branch contains some missing features and bug fixes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoidviewer/qmlpackages/containment/contents/ui/main.qml <span style="color: \
grey">(6558710)</span></li>
<li>plasmoidviewer/qmlpackages/containment/metadata.desktop <span style="color: \
grey">(9ddd217)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Background.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <span style="color: \
grey">(e5bedf3)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/view.h <span style="color: grey">(4cc472b)</span></li>
<li>plasmoidviewer/view.cpp <span style="color: grey">(511fe66)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml <span \
style="color: grey">(b23e098)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml <span \
style="color: grey">(33d72c0)</span></li>
<li>plasmoidviewer/CMakeLists.txt <span style="color: grey">(30de8e2)</span></li>
<li>plasmoidviewer/fullview.h <span style="color: grey">(7d4c70d)</span></li>
<li>plasmoidviewer/fullview.cpp <span style="color: grey">(898931a)</span></li>
<li>plasmoidviewer/main.cpp <span style="color: grey">(9b41e78)</span></li>
<li>plasmoidviewer/qmlpackages/containment/Messages.sh <span style="color: \
grey">(c8a9b60)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js <span \
style="color: grey">(62e149a)</span></li>
<li>plasmoidviewer/qmlpackages/containment/contents/config/main.xml <span \
style="color: grey">(d889999)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114493/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic