[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Proposed fix for issue 330115
From:       Shantanu Tushar Jha <shantanu () kde ! org>
Date:       2014-02-18 14:28:48
Message-ID: CABQ4Km_bRhnRE1=3oLB3DMg+YZwN+X59VAz1Vz_b6MAc9Y1pBw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Your patch works fine for me, I see 00:45 AM without the patch and 12:45 PM
with the patch.


On Tue, Feb 18, 2014 at 6:55 PM, R.Harish Navnit <harishnavnit@gmail.com>wrote:

> I've made a patch for the issue and it's content can be found here :
> http://paste.kde.org/pcx7kgozj
>
> However , it still doesn't reflect in the PMC application . I'm still
> trying to figure out why ? I feel the required changes have been made.
> Are there any other files that have to be changed in order for the changes
> to reflect ?
> (I have very basic knowledge of QML). Do you have to reload the
> application(other than just closing and opening ?)
>
> Warm Regards.
>
> R.Harish Navnit
> The Enigma <http://harishnavnit.wordpress.com>
>
>
> On Mon, Feb 17, 2014 at 6:19 PM, R.Harish Navnit <harishnavnit@gmail.com>wrote:
>
>> On Sat, Feb 15, 2014 at 7:37 PM, Shantanu Tushar Jha <shantanu@kde.org>wrote:
>>
>>> Whats the status on this? If your patch is ready, head over to
>>> http://git.reviewboard.kde.org/ and submit a review.
>>>
>> Just returned back from Calicut today .  Will work on the patch and
>> submit a review at the earliest .
>> Sorry for the delay ...
>>
>> Regards.
>>  R.Harish Navnit
>> The Enigma <http://harishnavnit.wordpress.com>
>>
>>
>


-- 
Shantanu Tushar    (UTC +0530)
http://www.shantanutushar.com

[Attachment #5 (text/html)]

<div dir="ltr">Your patch works fine for me, I see 00:45 AM without the patch and \
12:45 PM with the patch.<br></div><div class="gmail_extra"><br><br><div \
class="gmail_quote">On Tue, Feb 18, 2014 at 6:55 PM, R.Harish Navnit <span \
dir="ltr">&lt;<a href="mailto:harishnavnit@gmail.com" \
target="_blank">harishnavnit@gmail.com</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div>I&#39;ve made a patch for the issue and \
it&#39;s content can be found here : <a href="http://paste.kde.org/pcx7kgozj" \
target="_blank">http://paste.kde.org/pcx7kgozj</a><br> <br></div>However , it still \
doesn&#39;t reflect in the PMC application . I&#39;m still trying to figure out why ? \
I feel the required changes have been made.<br> <div>Are there any other files that \
have to be changed in order for the changes to reflect ? </div><div>(I have very \
basic knowledge of QML). Do you have to reload the application(other than just \
closing and opening ?)</div>

<div><br></div><div>Warm Regards.</div></div><div class="gmail_extra"><span \
class="HOEnZb"><font color="#888888"><br clear="all"><div><div \
dir="ltr"><div>R.Harish Navnit<br></div><a href="http://harishnavnit.wordpress.com" \
target="_blank">The Enigma</a><br> </div></div></font></span><div><div class="h5">

<br><br><div class="gmail_quote">On Mon, Feb 17, 2014 at 6:19 PM, R.Harish Navnit \
<span dir="ltr">&lt;<a href="mailto:harishnavnit@gmail.com" \
target="_blank">harishnavnit@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

<div dir="ltr"><div>On Sat, Feb 15, 2014 at 7:37 PM, Shantanu Tushar Jha <span \
dir="ltr">&lt;<a href="mailto:shantanu@kde.org" \
target="_blank">shantanu@kde.org</a>&gt;</span> wrote:<br></div><div \
class="gmail_extra"> <div class="gmail_quote"><div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr">Whats the status on this? If your \
patch is ready, head over to <a href="http://git.reviewboard.kde.org/" \
target="_blank">http://git.reviewboard.kde.org/</a> and submit a review.<br>


</div></blockquote></div><div>Just returned back from Calicut today .  Will work on \
the patch and submit a review at the earliest . <br></div><div>Sorry for the delay \
...<br><br></div><div><div>Regards.<br clear="all"> <div><div dir="ltr">
<div>R.Harish Navnit<br></div><a href="http://harishnavnit.wordpress.com" \
target="_blank">The Enigma</a><br></div></div> </div></div></div><br></div></div>
</blockquote></div><br></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br>Shantanu Tushar    (UTC \
+0530)<br><a href="http://www.shantanutushar.com" \
target="_blank">http://www.shantanutushar.com</a> </div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic