'Re: Review Request 115726: Deafult for not executing kwalletmanager once a wallet is open'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115726: Deafult for not executing kwalletmanager once a wallet is open
From:       Àlex_Fiestas <afiestas () kde ! org>
Date:       2014-02-17 16:12:53
Message-ID: 20140217161253.430.37469 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115726/
-----------------------------------------------------------

(Updated Feb. 17, 2014, 4:12 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Runtime, kde-workspace and Plasma.

Repository: kde-runtime

Description
-------

Given that in 4.13 we want people to use pam to open the wallet it
makes little sense to execute the wallet automatically.

Other commits changing the default have been pushed to kwallet and
kwalletmanager

This review goes together with:
https://git.reviewboard.kde.org/r/115727/
https://git.reviewboard.kde.org/r/115728/

Diffs
-----

  kwalletd/CMakeLists.txt 9c5ca92 
  kwalletd/kwallet-4.13.upd PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115726/diff/

Testing
-------

Thanks,

Àlex Fiestas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115726/">https://git.reviewboard.kde.org/r/115726/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime, kde-workspace and Plasma.</div>
<div>By Àlex Fiestas.</div>

<p style="color: grey;"><i>Updated Feb. 17, 2014, 4:12 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Given that in 4.13 we want people to use pam to open the wallet it makes \
little sense to execute the wallet automatically.

Other commits changing the default have been pushed to kwallet and
kwalletmanager

This review goes together with:
https://git.reviewboard.kde.org/r/115727/
https://git.reviewboard.kde.org/r/115728/</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwalletd/CMakeLists.txt <span style="color: grey">(9c5ca92)</span></li>

 <li>kwalletd/kwallet-4.13.upd <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115726/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 