[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115409: Workaround battery detection at runtime
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2014-02-15 22:02:44
Message-ID: 20140215220244.28960.11833 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115409/#review49877
-----------------------------------------------------------
Ship it!
I've recently debugged a similar issue in Plasma Next. There, the event seems to \
arrive just fine, but the plasmoid.status was never updated. Just calling it once \
helped the problem, but I wasn't able to figure out why. I don't see anything special \
happening when calling plasmoid.status, other than it's harmless and makes the \
battery appear reliably. That's 2c18797012 in kdeworkspace[master].
I've tried the same in 4.x, but it didn't work. Since your patch won't make it into \
Plasma Next, I think I can live with the expense of this hack you propose, compared \
to its benefits (i.e. it makes things work for our users).
- Sebastian Kügler
On Feb. 15, 2014, 4:58 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115409/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2014, 4:58 p.m.)
>
>
> Review request for Plasma, Solid and Sebastian Kügler.
>
>
> Bugs: 324847
> http://bugs.kde.org/show_bug.cgi?id=324847
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> For some reason when a new battery appears (eg. mouse plugged in), the battery does \
> not appear right away in the battery monitor. It appears instantly in \
> plasmaengineexplorer, however. I am really clueless on to what causes this, so I \
> just throw this patch in for enlightenment as it sort of makes it work. :/
>
> Diffs
> -----
>
> plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml c1c0169
>
> Diff: https://git.reviewboard.kde.org/r/115409/diff/
>
>
> Testing
> -------
>
> Has some minor glitches, please see bugreport.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115409/">https://git.reviewboard.kde.org/r/115409/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've recently \
debugged a similar issue in Plasma Next. There, the event seems to arrive just fine, \
but the plasmoid.status was never updated. Just calling it once helped the problem, \
but I wasn't able to figure out why. I don't see anything special happening \
when calling plasmoid.status, other than it's harmless and makes the battery \
appear reliably. That's 2c18797012 in kdeworkspace[master].
I've tried the same in 4.x, but it didn't work. Since your patch won't \
make it into Plasma Next, I think I can live with the expense of this hack you \
propose, compared to its benefits (i.e. it makes things work for our users).</pre> \
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 15th, 2014, 4:58 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Solid and Sebastian Kügler.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2014, 4:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=324847">324847</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For some reason when a new battery appears (eg. mouse plugged in), the \
battery does not appear right away in the battery monitor. It appears instantly in \
plasmaengineexplorer, however. I am really clueless on to what causes this, so I just \
throw this patch in for enlightenment as it sort of makes it work. :/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Has some minor glitches, please see bugreport.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml <span \
style="color: grey">(c1c0169)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115409/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic