[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-02-13 23:06:13
Message-ID: 20140213230613.30725.3145 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115727/#review49755
-----------------------------------------------------------
Ship it!
Makes a lot of sense.
Pedantic Comments:
fix the typo in your commit message.
Deafult -> Default
Execute the wallet -> Execute the walletManager
- David Edmundson
On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115727/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 5:13 p.m.)
>
>
> Review request for KDE Runtime, kde-workspace and Plasma.
>
>
> Repository: kwallet
>
>
> Description
> -------
>
> Given that in 4.13 we want people to use pam to open the wallet it
> makes little sense to execute the wallet automatically.
>
> Other commits changing the default have been pushed to runtime and
> kwalletmanager
>
>
> Diffs
> -----
>
> src/konfigurator/konfigurator.cpp b9f6edb
> src/manager/kwalletmanager.cpp 355fda7
>
> Diff: https://git.reviewboard.kde.org/r/115727/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115727/">https://git.reviewboard.kde.org/r/115727/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes a lot of sense.
Pedantic Comments:
fix the typo in your commit message.
Deafult -> Default
Execute the wallet -> Execute the walletManager</pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On February 13th, 2014, 5:13 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime, kde-workspace and Plasma.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2014, 5:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Given that in 4.13 we want people to use pam to open the wallet it makes \
little sense to execute the wallet automatically.
Other commits changing the default have been pushed to runtime and
kwalletmanager
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/konfigurator/konfigurator.cpp <span style="color: \
grey">(b9f6edb)</span></li>
<li>src/manager/kwalletmanager.cpp <span style="color: grey">(355fda7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115727/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic