'Re: Review Request 115709: Monitor the QQmlParser status from dialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115709: Monitor the QQmlParser status from dialog
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-02-13 10:27:12
Message-ID: 20140213102712.8904.76276 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115709/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 10:27 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-framework

Description
-------

Monitor the QQmlParser status from dialog

This way we only call the expensive syncToMainItemSize once we have all
the information to accurately position the window.

The previous approach using the timer to limit the calls doesn't work entirely (according to my
qDebug inside the function) especially with the multiple threads to compile things.

This patch seems to prevent the dialog ever jumping around on load which I sometimes saw.

Diffs
-----

  src/declarativeimports/core/dialog.h 3c0df8b 
  src/declarativeimports/core/dialog.cpp b353caf 

Diff: https://git.reviewboard.kde.org/r/115709/diff/

Testing
-------

Thanks,

David Edmundson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115709/">https://git.reviewboard.kde.org/r/115709/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Feb. 13, 2014, 10:27 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Monitor the QQmlParser status from dialog

This way we only call the expensive syncToMainItemSize once we have all
the information to accurately position the window.

The previous approach using the timer to limit the calls doesn&#39;t work entirely \
(according to my qDebug inside the function) especially with the multiple threads to \
compile things.

This patch seems to prevent the dialog ever jumping around on load which I sometimes \
saw.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/dialog.h <span style="color: \
grey">(3c0df8b)</span></li>

 <li>src/declarativeimports/core/dialog.cpp <span style="color: \
grey">(b353caf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115709/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 