[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112727: Shrink (fancy) unhide trigger when entered while FS window is active
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-02-09 20:02:52
Message-ID: 20140209200252.8972.99169 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 24, 2013, 10:31 a.m., Martin Gräßlin wrote:
> > > no idea whether that's acceptable
> > shouldn't be much of an issue. KWindowSystem is emitting a signal, isn't it? \
> > activeWindowChanged()
>
> Thomas Lübking wrote:
> There's been concerns about waking up when windows were moved and KWindowSystem has \
> no disconnectNotify implementation, so once you hooked onto KWindowSystem signals, \
> you're afair not easily getting rid of it's X11 event filtering.
> Christoph Feck wrote:
> Thomas, bug 217560 comment #19 has a simpler patch, but we are unsure which route \
> to go. Could you have a look?
It appears to me that patch would only apply when the dock is autohidden (and the \
trigger thus re/created) while there's an active fullscreen window, while that should \
not (or rather hardly) be possible, since ::hintOrUnhide() exits early when there's a \
fullscreen window. Ie. you'd need the panel visible, then get an active fullscreen \
window, then have the panel hidden. If the active fs window enters while the panel is \
hidden, the patch would not have any effect?!?
-> Has anybody checked whether that patch actually works?
Iff it does, the implications should be
- the panel is shown/hidden at least once while there's a fullscreen window
- if the panel by this event claims the focus, this will break the "active fullscreen \
window" condition (not sure, but i think some plasmoid with a lineedit does?)
All approaches might for the latter also have touble with F(S)UM focus policy - not \
sure whether that's an itch to scratch, but I also doubt that I tested it.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112727/#review40664
-----------------------------------------------------------
On Sept. 14, 2013, 2:36 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112727/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2013, 2:36 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.
>
>
> Bugs: 217560
> http://bugs.kde.org/show_bug.cgi?id=217560
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Drawback: the next trigger will go unfancied (would require listening to active \
> window changes, no idea whether that's acceptable) but that's still much better \
> than occluding 30 outer px of a window (see bug and \
> http://forum.kde.org/viewtopic.php?f=111&t=112163)
> Notice that
> a) nor auto unhiding neither hinting happens at all while there's a(n active) \
> fullscreen window - this is unchanged (see early exit in patched branch) b) the \
> patch does nothing if you don't attempt to enter the occluded area of a fullscreen \
> window (so not even the next hinting will be affected)
>
> Diffs
> -----
>
> plasma/desktop/shell/panelview.cpp dcd051a
>
> Diff: https://git.reviewboard.kde.org/r/112727/diff/
>
>
> Testing
> -------
>
> m_unhideTrigger shrinks and the next unhide is not indicated (but the panel \
> appears), subsequent indication remains unaffected.
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112727/">https://git.reviewboard.kde.org/r/112727/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 24th, 2013, 10:31 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">> no idea whether that's acceptable shouldn't be much of an \
issue. KWindowSystem is emitting a signal, isn't it? activeWindowChanged()</pre> \
</blockquote>
<p>On September 26th, 2013, 12:15 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's been \
concerns about waking up when windows were moved and KWindowSystem has no \
disconnectNotify implementation, so once you hooked onto KWindowSystem signals, \
you're afair not easily getting rid of it's X11 event filtering.</pre> \
</blockquote>
<p>On February 9th, 2014, 5:57 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thomas, bug 217560 \
comment #19 has a simpler patch, but we are unsure which route to go. Could you have \
a look?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It appears to me that \
patch would only apply when the dock is autohidden (and the trigger thus re/created) \
while there's an active fullscreen window, while that should not (or rather \
hardly) be possible, since ::hintOrUnhide() exits early when there's a fullscreen \
window. Ie. you'd need the panel visible, then get an active fullscreen window, \
then have the panel hidden. If the active fs window enters while the panel is hidden, \
the patch would not have any effect?!?
-> Has anybody checked whether that patch actually works?
Iff it does, the implications should be
- the panel is shown/hidden at least once while there's a fullscreen window
- if the panel by this event claims the focus, this will break the "active \
fullscreen window" condition (not sure, but i think some plasmoid with a \
lineedit does?)
All approaches might for the latter also have touble with F(S)UM focus policy - not \
sure whether that's an itch to scratch, but I also doubt that I tested it.</pre> \
<br />
<p>- Thomas</p>
<br />
<p>On September 14th, 2013, 2:36 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2013, 2:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=217560">217560</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Drawback: the next trigger will go unfancied (would require listening to \
active window changes, no idea whether that's acceptable) but that's still \
much better than occluding 30 outer px of a window (see bug and \
http://forum.kde.org/viewtopic.php?f=111&t=112163)
Notice that
a) nor auto unhiding neither hinting happens at all while there's a(n active) \
fullscreen window - this is unchanged (see early exit in patched branch) b) the patch \
does nothing if you don't attempt to enter the occluded area of a fullscreen \
window (so not even the next hinting will be affected)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">m_unhideTrigger shrinks and the next unhide is not indicated (but the \
panel appears), subsequent indication remains unaffected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(dcd051a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112727/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic