[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115475: Split KRunner out of plasma-framework
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-02-04 16:05:25
Message-ID: 20140204160525.25903.56367 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 4, 2014, 3:42 p.m., Marco Martin wrote:
> > hm, no...
> > while the changes in this rr are fine, I would really really want the new repo \
> > with history preserved, at least the classes in src/plasma, with git \
> > filter-branch. for examples and tests, history is less important.
>
> David Edmundson wrote:
> It has history via git graft (tested here)
>
> Marco Martin wrote:
> how is done?
> just cloning the new repository it has exactly one commit
path/to/qt5/qtrepotools/bin/git-qt-grafts /path/to/plasma-framework/
then git log etc will work.
(I had to run mkdir .git/info to make it work, but that's a bug fixed in \
https://codereview.qt-project.org/#change,77371)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115475/#review48931
-----------------------------------------------------------
On Feb. 4, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115475/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 3:33 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Splitted out KRunner so we can use it from any solution and eventually move out \
> from it, if required.
> It can be found now in kde:scratch/apol/krunner.
>
>
> Diffs
> -----
>
> src/plasma/includes/Plasma/RunnerScript f078d03
> src/plasma/pluginloader.cpp 4d8633c
> src/plasma/private/abstractrunner_p.h ada3222
> src/plasma/private/runnerjobs.cpp 880a3c5
> src/plasma/private/runnerjobs_p.h 43c6da2
> src/plasma/private/storage.cpp c9d7100
> src/plasma/querymatch.h 7fe66fb
> src/plasma/querymatch.cpp 8353e8f
> src/plasma/runnercontext.h 97d654a
> src/plasma/runnercontext.cpp 8b74614
> src/plasma/runnermanager.h 1963f66
> src/plasma/runnermanager.cpp 69f8ef4
> src/plasma/runnersyntax.h 63a2624
> src/plasma/runnersyntax.cpp 2984d7a
> src/plasma/scripting/runnerscript.h 1175d25
> src/plasma/scripting/runnerscript.cpp 366d3ef
> src/plasma/scripting/scriptengine.h 013e983
> src/plasma/scripting/scriptengine.cpp 2a0dfd9
> src/scriptengines/python/CMakeLists.txt 2bd980b
> src/plasma/includes/Plasma/RunnerContext 0c0d283
> src/plasma/includes/Plasma/RunnerManager 95e00ec
> src/declarativeimports/krunnermodel/qmldir 6e4fe5b
> src/declarativeimports/krunnermodel/runnermodelplugin.h 65d2faa
> src/declarativeimports/krunnermodel/runnermodelplugin.cpp 3b466bf
> src/plasma/CMakeLists.txt 064d3cc
> src/plasma/abstractrunner.h 219fa05
> src/plasma/abstractrunner.cpp c01ac18
> src/plasma/autotests/CMakeLists.txt 06c3d15
> src/plasma/autotests/runnercontexttest.h 1c6feb7
> src/plasma/autotests/runnercontexttest.cpp bb38d3e
> src/plasma/data/servicetypes/plasma-runner.desktop 08cd066
> src/plasma/includes/Plasma/AbstractRunner fbc77e8
> src/plasma/includes/Plasma/QueryMatch d6fc700
> examples/runner/homefilesrunner.cpp 39d0205
> examples/runner/plasma-runner-example-homefiles.desktop 296d1d0
> src/declarativeimports/CMakeLists.txt db88828
> src/declarativeimports/core/corebindingsplugin.cpp 1ce43d4
> src/declarativeimports/core/runnermodel.h bd21c21
> src/declarativeimports/core/runnermodel.cpp 170f511
> src/declarativeimports/core/tests/CMakeLists.txt b49f91d
> src/declarativeimports/core/tests/main.cpp 1feee19
> src/declarativeimports/krunnermodel/CMakeLists.txt f7405b6
> examples/runner/CMakeLists.txt b9c1511
> examples/runner/Messages.sh 4fb602e
> examples/runner/homefilesrunner.h c535380
>
> Diff: https://git.reviewboard.kde.org/r/115475/diff/
>
>
> Testing
> -------
>
> Everything still builds.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115475/">https://git.reviewboard.kde.org/r/115475/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 4th, 2014, 3:42 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hm, no... while the changes in this rr are fine, I would really really \
want the new repo with history preserved, at least the classes in src/plasma, with \
git filter-branch. for examples and tests, history is less important.</pre>
</blockquote>
<p>On February 4th, 2014, 3:47 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It has history via git \
graft (tested here)</pre> </blockquote>
<p>On February 4th, 2014, 3:51 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">how is done? just \
cloning the new repository it has exactly one commit</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">path/to/qt5/qtrepotools/bin/git-qt-grafts /path/to/plasma-framework/
then git log etc will work.
(I had to run mkdir .git/info to make it work, but that's a bug fixed in \
https://codereview.qt-project.org/#change,77371)</pre> <br />
<p>- David</p>
<br />
<p>On February 4th, 2014, 3:33 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2014, 3:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Splitted out KRunner so we can use it from any solution and eventually \
move out from it, if required.
It can be found now in kde:scratch/apol/krunner.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Everything still builds.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/includes/Plasma/RunnerScript <span style="color: \
grey">(f078d03)</span></li>
<li>src/plasma/pluginloader.cpp <span style="color: grey">(4d8633c)</span></li>
<li>src/plasma/private/abstractrunner_p.h <span style="color: \
grey">(ada3222)</span></li>
<li>src/plasma/private/runnerjobs.cpp <span style="color: \
grey">(880a3c5)</span></li>
<li>src/plasma/private/runnerjobs_p.h <span style="color: \
grey">(43c6da2)</span></li>
<li>src/plasma/private/storage.cpp <span style="color: grey">(c9d7100)</span></li>
<li>src/plasma/querymatch.h <span style="color: grey">(7fe66fb)</span></li>
<li>src/plasma/querymatch.cpp <span style="color: grey">(8353e8f)</span></li>
<li>src/plasma/runnercontext.h <span style="color: grey">(97d654a)</span></li>
<li>src/plasma/runnercontext.cpp <span style="color: grey">(8b74614)</span></li>
<li>src/plasma/runnermanager.h <span style="color: grey">(1963f66)</span></li>
<li>src/plasma/runnermanager.cpp <span style="color: grey">(69f8ef4)</span></li>
<li>src/plasma/runnersyntax.h <span style="color: grey">(63a2624)</span></li>
<li>src/plasma/runnersyntax.cpp <span style="color: grey">(2984d7a)</span></li>
<li>src/plasma/scripting/runnerscript.h <span style="color: \
grey">(1175d25)</span></li>
<li>src/plasma/scripting/runnerscript.cpp <span style="color: \
grey">(366d3ef)</span></li>
<li>src/plasma/scripting/scriptengine.h <span style="color: \
grey">(013e983)</span></li>
<li>src/plasma/scripting/scriptengine.cpp <span style="color: \
grey">(2a0dfd9)</span></li>
<li>src/scriptengines/python/CMakeLists.txt <span style="color: \
grey">(2bd980b)</span></li>
<li>src/plasma/includes/Plasma/RunnerContext <span style="color: \
grey">(0c0d283)</span></li>
<li>src/plasma/includes/Plasma/RunnerManager <span style="color: \
grey">(95e00ec)</span></li>
<li>src/declarativeimports/krunnermodel/qmldir <span style="color: \
grey">(6e4fe5b)</span></li>
<li>src/declarativeimports/krunnermodel/runnermodelplugin.h <span style="color: \
grey">(65d2faa)</span></li>
<li>src/declarativeimports/krunnermodel/runnermodelplugin.cpp <span style="color: \
grey">(3b466bf)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(064d3cc)</span></li>
<li>src/plasma/abstractrunner.h <span style="color: grey">(219fa05)</span></li>
<li>src/plasma/abstractrunner.cpp <span style="color: grey">(c01ac18)</span></li>
<li>src/plasma/autotests/CMakeLists.txt <span style="color: \
grey">(06c3d15)</span></li>
<li>src/plasma/autotests/runnercontexttest.h <span style="color: \
grey">(1c6feb7)</span></li>
<li>src/plasma/autotests/runnercontexttest.cpp <span style="color: \
grey">(bb38d3e)</span></li>
<li>src/plasma/data/servicetypes/plasma-runner.desktop <span style="color: \
grey">(08cd066)</span></li>
<li>src/plasma/includes/Plasma/AbstractRunner <span style="color: \
grey">(fbc77e8)</span></li>
<li>src/plasma/includes/Plasma/QueryMatch <span style="color: \
grey">(d6fc700)</span></li>
<li>examples/runner/homefilesrunner.cpp <span style="color: \
grey">(39d0205)</span></li>
<li>examples/runner/plasma-runner-example-homefiles.desktop <span style="color: \
grey">(296d1d0)</span></li>
<li>src/declarativeimports/CMakeLists.txt <span style="color: \
grey">(db88828)</span></li>
<li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: \
grey">(1ce43d4)</span></li>
<li>src/declarativeimports/core/runnermodel.h <span style="color: \
grey">(bd21c21)</span></li>
<li>src/declarativeimports/core/runnermodel.cpp <span style="color: \
grey">(170f511)</span></li>
<li>src/declarativeimports/core/tests/CMakeLists.txt <span style="color: \
grey">(b49f91d)</span></li>
<li>src/declarativeimports/core/tests/main.cpp <span style="color: \
grey">(1feee19)</span></li>
<li>src/declarativeimports/krunnermodel/CMakeLists.txt <span style="color: \
grey">(f7405b6)</span></li>
<li>examples/runner/CMakeLists.txt <span style="color: grey">(b9c1511)</span></li>
<li>examples/runner/Messages.sh <span style="color: grey">(4fb602e)</span></li>
<li>examples/runner/homefilesrunner.h <span style="color: \
grey">(c535380)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115475/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic