From kde-panel-devel Fri Jan 31 18:07:20 2014 From: "Alex Merry" Date: Fri, 31 Jan 2014 18:07:20 +0000 To: kde-panel-devel Subject: Re: Review Request 114260: Port mouse dataengine Message-Id: <20140131180720.19041.56810 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139119166611413 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7196852379708778580==" --===============7196852379708778580== Content-Type: multipart/alternative; boundary="===============6195101878603357574==" --===============6195101878603357574== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Dec. 8, 2013, 12:08 p.m., Bhushan Shah wrote: > > plasma/generic/dataengines/mouse/mouseengine.cpp, line 34 > > > > > > You should call init() here. Have a look at http://community.kde.org/Plasma/PortingTolibplasma2#DataEngine for changes in API. Any update on this? - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review45349 ----------------------------------------------------------- On Dec. 3, 2013, 9:51 a.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114260/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 9:51 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kde-workspace > > > Description > ------- > > = subject. > > I commented the lines about scheduleSourcesUpdated(). What to do with them? > > > Diffs > ----- > > plasma/generic/dataengines/CMakeLists.txt 3e94325 > plasma/generic/dataengines/mouse/CMakeLists.txt 29cab87 > plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8 > plasma/generic/dataengines/mouse/cursornotificationhandler.cpp 3cb9add > plasma/generic/dataengines/mouse/mouseengine.h d55565d > plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 > > Diff: https://git.reviewboard.kde.org/r/114260/diff/ > > > Testing > ------- > > Builds > > > Thanks, > > Andrea Scarpino > > --===============6195101878603357574== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/

On December 8th, 2013, 12:08 p.m. UTC, Bhushan Shah wrote:
plasma/generic/dataengines/mouse/mouseengine.cpp (Diff revision 2)
MouseEngine::MouseEngine(QObject* parent, const QVariantList& args)
34
    Q_UNUSED(args)
34
    Q_UNUSED(args)
You should call init() here. Have a look at http://community.kde.org/Plasma/PortingTolibplasma2#DataEngine for changes in API.

Any update on this?

- Alex

On December 3rd, 2013, 9:51 a.m. UTC, Andrea Scarpino wrote:

Review request for KDE Frameworks and Plasma.

By Andrea Scarpino.

Updated Dec. 3, 2013, 9:51 a.m.

Repository: kde-workspace

Description

= subject.

I commented the lines about scheduleSourcesUpdated(). What to do with them?

Testing

Builds

Diffs

plasma/generic/dataengines/CMakeLists.txt (3e94325)
plasma/generic/dataengines/mouse/CMakeLists.txt (29cab87)
plasma/generic/dataengines/mouse/cursornotificationhandler.h (3b571f8)
plasma/generic/dataengines/mouse/cursornotificationhandler.cpp (3cb9add)
plasma/generic/dataengines/mouse/mouseengine.h (d55565d)
plasma/generic/dataengines/mouse/mouseengine.cpp (19a7fb7)

--===============6195101878603357574==-- --===============7196852379708778580== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7196852379708778580==--