[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113236: make the warnings accessible from QML
From: "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date: 2014-01-30 15:28:02
Message-ID: 20140130152802.32672.52859 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 30, 2014, 2:59 p.m., David Edmundson wrote:
> > This patch doesn't match the review description at all. It just prints the error messages.
the idea of the patch was to pass the errors with
"m_qmlObject->rootObject()->setProperty("warnings", warn);"
because we needed it for plasmoidviewer. But with the qC* methods
there is a better way of doing it. qInstallMessageHandler and the qC* methods
will do the job. So I will discard this review
- Giorgos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113236/#review48630
-----------------------------------------------------------
On Oct. 14, 2013, 7:51 a.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113236/
> -----------------------------------------------------------
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This patch takes the QQmlErrors of QQmlEngine::errors signal and passes them
> to a property of QmlObject, so the errors become accessible from QML.
>
>
> Diffs
> -----
>
> src/scriptengines/qml/plasmoid/appletinterface.cpp 214a4b1
>
> Diff: https://git.reviewboard.kde.org/r/113236/diff/
>
>
> Testing
> -------
>
> I have create a `property string warnings` inside in a containment
> and I was able to print the warnings with
>
> `onWarningsChanged: console.log(warnings)`
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113236/">https://git.reviewboard.kde.org/r/113236/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 30th, 2014, 2:59 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch doesn't match the review description at all. It just \
prints the error messages. </pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the idea of the patch \
was to pass the errors with \
"m_qmlObject->rootObject()->setProperty("warnings", warn);" \
because we needed it for plasmoidviewer. But with the qC* methods
there is a better way of doing it. qInstallMessageHandler and the qC* methods
will do the job. So I will discard this review</pre>
<br />
<p>- Giorgos</p>
<br />
<p>On October 14th, 2013, 7:51 a.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch takes the QQmlErrors of QQmlEngine::errors signal and passes \
them to a property of QmlObject, so the errors become accessible from QML.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have create a `property string warnings` inside in a containment and I \
was able to print the warnings with
`onWarningsChanged: console.log(warnings)`</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(214a4b1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113236/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic