From kde-panel-devel Thu Jan 30 14:52:55 2014 From: "David Edmundson" Date: Thu, 30 Jan 2014 14:52:55 +0000 To: kde-panel-devel Subject: Re: Review Request 114566: Plasmate: Port remoteinstaller to Qt5/KF5 Message-Id: <20140130145255.32672.71093 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139109358401344 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8256541446027489451==" --===============8256541446027489451== Content-Type: multipart/alternative; boundary="===============5673572297387396199==" --===============5673572297387396199== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114566/#review48627 ----------------------------------------------------------- Ship it! Ship It! - David Edmundson On Jan. 5, 2014, 5:36 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114566/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2014, 5:36 p.m.) > > > Review request for Plasma and Giorgos Tsiapaliokas. > > > Repository: plasmate > > > Description > ------- > > Hello, > > This patch ports the remoteinstaller to Qt5/KF5. > > > Diffs > ----- > > plasmate/CMakeLists.txt 55e7453 > plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97 > plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33 > > Diff: https://git.reviewboard.kde.org/r/114566/diff/ > > > Testing > ------- > > I wasn't able to test if it works. Because remoteinstaller is using the KUrlRequester, > which it segfaults... I have open a thread on the frameworks ML. > > > Thanks, > > Antonis Tsiapaliokas > > --===============5673572297387396199== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114566/

Ship it!

Ship It!

- David Edmundson

On January 5th, 2014, 5:36 p.m. UTC, Antonis Tsiapaliokas wrote:

Review request for Plasma and Giorgos Tsiapaliokas.

By Antonis Tsiapaliokas.

Updated Jan. 5, 2014, 5:36 p.m.

Repository: plasmate

Description

Hello,

This patch ports the remoteinstaller to Qt5/KF5.

Testing

I wasn't able to test if it works. Because remoteinstaller is using the KUrlRequester,
which it segfaults... I have open a thread on the frameworks ML.

Diffs

plasmate/CMakeLists.txt (55e7453)
plasmate/publisher/remoteinstaller/remoteinstaller.cpp (5f4de97)
plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp (3b41b33)

View Diff

--===============5673572297387396199==-- --===============8256541446027489451== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8256541446027489451==--