From kde-panel-devel Thu Jan 30 14:51:30 2014 From: "Bhushan Shah" Date: Thu, 30 Jan 2014 14:51:30 +0000 To: kde-panel-devel Subject: Re: Review Request 112959: Add color picker in plasmaextracomponents Message-Id: <20140130145130.2191.83421 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139109350001316 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3172253351738373009==" --===============3172253351738373009== Content-Type: multipart/alternative; boundary="===============5287245457424918695==" --===============5287245457424918695== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Jan. 30, 2014, 8:14 p.m., David Edmundson wrote: > > src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml, line 2 > > > > > > That's not your name. but code was! ;) - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112959/#review48618 ----------------------------------------------------------- On Jan. 30, 2014, 8:20 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112959/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 8:20 p.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > Add color picker in PlasmaExtras > > > Diffs > ----- > > src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml PRE-CREATION > src/declarativeimports/plasmaextracomponents/qml/qmldir c59e62f > > Diff: https://git.reviewboard.kde.org/r/112959/diff/ > > > Testing > ------- > > > Thanks, > > Bhushan Shah > > --===============5287245457424918695== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112959/

On January 30th, 2014, 8:14 p.m. IST, David Edmundson wrote:

src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml (Diff revision 2) 

    2
    
 *  Copyright 2013 Marco Martin <mart@kde.org>

  


 




  
That's not your name.

 









but code was! ;)








- Bhushan






On January 30th, 2014, 8:20 p.m. IST, Bhushan Shah wrote:











 

  


Review request for Plasma and Marco Martin.


By Bhushan Shah.




Updated Jan. 30, 2014, 8:20 p.m.












 Repository: 
plasma-framework





Description 

 

 

  
   
Add color picker in PlasmaExtras

  		
 







Diffs 


    

 
  • src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml (PRE-CREATION)
    • 

 
  • src/declarativeimports/plasmaextracomponents/qml/qmldir (c59e62f)
    • 





View Diff








  		
 











  

 



--===============5287245457424918695==--

--===============3172253351738373009==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============3172253351738373009==--