From kde-panel-devel Thu Jan 30 14:03:30 2014 From: "David Edmundson" Date: Thu, 30 Jan 2014 14:03:30 +0000 To: kde-panel-devel Subject: Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's windo Message-Id: <20140130140330.32672.37863 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139109063032345 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2032718394406889580==" --===============2032718394406889580== Content-Type: multipart/alternative; boundary="===============0686165107961065936==" --===============0686165107961065936== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115393/ ----------------------------------------------------------- (Updated Jan. 30, 2014, 2:03 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description ------- For the WidgetExplorer we want to show the tooltips to the right of the scrollbar in the view, not to the right of the delegate the tooltip is for. This patch adds a boolean flag which shifts it to the nearest point to the visualParent which is outside the visualParent's window - in this case outside the scrollbar. I have also introduced a manual test for Dialog Positioning, and includied some fixes in the original logic. Diffs ----- src/declarativeimports/core/tests/manual/dialog_positioning.qml PRE-CREATION src/declarativeimports/core/dialog.cpp 0248596 src/declarativeimports/core/dialog.h dc2b688 Diff: https://git.reviewboard.kde.org/r/115393/diff/ Testing ------- Thanks, David Edmundson --===============0686165107961065936== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115393/

This change has been marked as submitted.

Review request for Plasma.

By David Edmundson.

Updated Jan. 30, 2014, 2:03 p.m.

Repository: plasma-framework

Description

For the WidgetExplorer we want to show the tooltips to the right of the
scrollbar in the view, not to the right of the delegate the tooltip is
for.
This patch adds a boolean flag which shifts it to the nearest point to
the visualParent which is outside the visualParent's window - in this
case outside the scrollbar.

I have also introduced a manual test for Dialog Positioning, and
includied some fixes in the original logic.

Diffs

src/declarativeimports/core/tests/manual/dialog_positioning.qml (PRE-CREATION)
src/declarativeimports/core/dialog.cpp (0248596)
src/declarativeimports/core/dialog.h (dc2b688)

View Diff

--===============0686165107961065936==-- --===============2032718394406889580== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2032718394406889580==--