'Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's windo'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's windo
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-01-30 13:39:23
Message-ID: 20140130133923.32672.27377 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115393/#review48608
-----------------------------------------------------------

Ship it!

Ship It!

- Marco Martin

On Jan. 30, 2014, 1:32 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115393/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 1:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> 
> For the WidgetExplorer we want to show the tooltips to the right of the
> scrollbar in the view, not to the right of the delegate the tooltip is
> for.
> This patch adds a boolean flag which shifts it to the nearest point to
> the visualParent which is outside the visualParent's window - in this
> case outside the scrollbar.
> 
> I have also introduced a manual test for Dialog Positioning, and
> includied some fixes in the original logic.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tests/manual/dialog_positioning.qml PRE-CREATION 
>   src/declarativeimports/core/dialog.cpp 0248596 
>   src/declarativeimports/core/dialog.h dc2b688 
> 
> Diff: https://git.reviewboard.kde.org/r/115393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115393/">https://git.reviewboard.kde.org/r/115393/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On January 30th, 2014, 1:32 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Jan. 30, 2014, 1:32 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> For the WidgetExplorer we want to show the tooltips to the right of the
scrollbar in the view, not to the right of the delegate the tooltip is
for.
This patch adds a boolean flag which shifts it to the nearest point to
the visualParent which is outside the visualParent&#39;s window - in this
case outside the scrollbar.

I have also introduced a manual test for Dialog Positioning, and
includied some fixes in the original logic.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/tests/manual/dialog_positioning.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>src/declarativeimports/core/dialog.cpp <span style="color: \
grey">(0248596)</span></li>

 <li>src/declarativeimports/core/dialog.h <span style="color: \
grey">(dc2b688)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115393/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 