--===============1963592767563327757==
Content-Type: multipart/signed; boundary="nextPart28408815.zVKq7WUnQs"; micalg="pgp-sha1"; protocol="application/pgp-signature"


--nextPart28408815.zVKq7WUnQs
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Wednesday, 2014-01-29, 18:17:21, Martin Graesslin wrote:
> On Wednesday 29 January 2014 18:07:02 Kevin Krammer wrote:
> > On Wednesday, 2014-01-29, 14:52:09, Martin Gr=E4=DFlin wrote:

> > > This obviously is not a solution. If I get positive reviews on it=
em 1 I
> > > will start to move the X11 implementation to the xcb plugin.
> >=20
> > I think that should be done independently, i.e. that is a good idea=
 in any
> > case, independent of whether the review for (1) finds support.
> > Moving the X11 systray icon implementation into the XCB plugin redu=
ces
> > platform specific code in qtbase/src/widgets and places it where it=

> > belongs
> > (the QPA).
>=20
> Yes, I agree. Just that for moving the X11 implementation into the XC=
B
> plugin I need the same extension to the API (the problem with the men=
u is
> also present there, already checked the implementation of the XCB plu=
gin).

Ah, I see.
Then I would even more so suggest to make the XCB adjustment right away=
, since=20
a "needed by" entry makes it more obvious why this is done in the first=
 place.

It says "this is more than just abstraction fun, this is really actuall=
y=20
needed" way more than this one sentence you currently have in the commi=
t=20
message.

> > Given the diff snippet X11 is the only remaining platform beside Wi=
ndows
> > where this has not happened yet.
> >=20
> > > Any support on the Qt code review will be appreciated :-)
> >=20
> > Looking at it right away.
>=20
> Cool, thanks.

No problem, done :)

Cheers,
Kevin
--=20
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

--nextPart28408815.zVKq7WUnQs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iD8DBQBS6TtbnKMhG6pzZJIRAnF2AJ9LUblEHY81JLdq7Qfqykmb0eIT4QCfUDbc
GrgkUX9EbcWHtcEHuuengpc=
=IKjF
-----END PGP SIGNATURE-----

--nextPart28408815.zVKq7WUnQs--


--===============1963592767563327757==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============1963592767563327757==--