[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115348: Create a MimeDatabase component that maps QMimeDatabase
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-01-28 13:36:41
Message-ID: 20140128133641.11809.31076 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115348/#review48465
-----------------------------------------------------------
Ship it!
src/declarativeimports/qtextracomponents/mimedatabase.h
<https://git.reviewboard.kde.org/r/115348/#comment34266>
If you return a map, it needs documenting on what the keys will be.
Long term this shouldn't be part of plasma but elsewhere.
I guess this relates to discussions on frameworks at the moment. It can move later.
- David Edmundson
On Jan. 28, 2014, 2:01 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115348/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 2:01 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Makes it possible to figure out mimetypes from QML.
>
>
> Diffs
> -----
>
> src/declarativeimports/qtextracomponents/CMakeLists.txt 0ae9e17
> src/declarativeimports/qtextracomponents/mimedatabase.h PRE-CREATION
> src/declarativeimports/qtextracomponents/mimedatabase.cpp PRE-CREATION
> src/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp d3f8149
>
> Diff: https://git.reviewboard.kde.org/r/115348/diff/
>
>
> Testing
> -------
>
> Works on my WIP changes for the QuickShare (was pastebin) plasmoid.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115348/">https://git.reviewboard.kde.org/r/115348/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115348/diff/1/?file=240778#file240778line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/qtextracomponents/mimedatabase.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_SCRIPTABLE</span> <span class="n">QVariantMap</span> <span \
class="n">mimeTypeForUrl</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QUrl</span> <span class="o">&</span> <span \
class="n">url</span><span class="p">)</span> <span class="k">const</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you \
return a map, it needs documenting on what the keys will be.
</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Long term this \
shouldn't be part of plasma but elsewhere. I guess this relates to discussions \
on frameworks at the moment. It can move later.</pre>
<p>- David Edmundson</p>
<br />
<p>On January 28th, 2014, 2:01 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2014, 2:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Makes it possible to figure out mimetypes from QML.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works on my WIP changes for the QuickShare (was pastebin) \
plasmoid.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/qtextracomponents/CMakeLists.txt <span style="color: \
grey">(0ae9e17)</span></li>
<li>src/declarativeimports/qtextracomponents/mimedatabase.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/qtextracomponents/mimedatabase.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp <span \
style="color: grey">(d3f8149)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115348/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic