[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Proposed fix for issue 330115
From:       Sinny Kumari <ksinny () gmail ! com>
Date:       2014-01-28 12:15:41
Message-ID: CABbDtLo-f++JLSmVZ=ZT-tY9WkPYCfNd7xO832jCcEZUeKCXWA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Tue, Jan 28, 2014 at 4:21 PM, R.Harish Navnit <harishnavnit@gmail.com>wrote:

> On Mon, Jan 27, 2014 at 10:02 PM, Shantanu Tushar Jha <shantanu@kde.org>wrote:
>
>> The diff you get should look like this http://pastebin.kde.org/pcydxtqcg.
>>
>
>
>> The easier thing imo would be to make a fresh clone, re-apply your changes
>>
> Oh my god ! Okay , this time I'll try working with Kubuntu 13.10
>
>
>>  and remember not to add the build dir to your commits.
>>
> Does this hold true for this project alone or in general ?
>
>
Yes, build directory is never part of any project because files inside
build directory are auto-generated after compiling on your local machine
and these files varies with machine to machine. You can check source tree
https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repositoryof
PMC or any other project and you will see that build is not added
there.

[Attachment #5 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, \
Jan 28, 2014 at 4:21 PM, R.Harish Navnit <span dir="ltr">&lt;<a \
href="mailto:harishnavnit@gmail.com" \
target="_blank">harishnavnit@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="im">On Mon, Jan 27, \
2014 at 10:02 PM, Shantanu Tushar Jha <span dir="ltr">&lt;<a \
href="mailto:shantanu@kde.org" target="_blank">shantanu@kde.org</a>&gt;</span> \
wrote:<br>

</div><div class="gmail_extra"><div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr">The diff you get should look like \
this <a href="http://pastebin.kde.org/pcydxtqcg" \
target="_blank">http://pastebin.kde.org/pcydxtqcg</a> .</div>


</blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"> The \
easier thing imo would be to make a fresh clone, re-apply your changes</div>


</blockquote></div><div>Oh my god ! Okay , this time I&#39;ll try working with \
Kubuntu 13.10<br> <br></div><div class="im"><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">


<div dir="ltr"> and remember not to add the build dir to your \
commits.<br></div></blockquote></div><div>Does this hold true for this project alone \
or in general ?<br><br></div></div></div></div></blockquote><div><br></div>

<div>Yes, build directory is never part of any project because files inside build \
directory are auto-generated after compiling on your local machine and these files \
varies with machine to machine. You can check source tree <a \
href="https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/reposi \
tory">https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository</a> \
of PMC or any other project and you will see that build is not added there.<br>

<br></div></div></div></div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]