[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115301: Add OSD notifications to plasma-shell
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-01-24 17:22:08
Message-ID: 20140124172208.10271.42054 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 24, 2014, 4:56 p.m., David Edmundson wrote:
> > src/shell/osd.cpp, line 118
> > <https://git.reviewboard.kde.org/r/115301/diff/1/?file=240477#file240477line118>
> >
> > This seems a bit risky?
> >
> > Is it relying on the root item being a Plasma.Dialog?
> >
> > Given we load from a look & feel package which anyone can alter at least qFatal \
> > with an appropriate error message.
> > Probably do this on show() as that's going to be called before hide().
if it doesn't anymore use qwindow directly, it can just set the "visible" property on \
it.. would then be on the responsibility of the osd root object to implement a \
visible property if it isn't using Dialog, but anyways, no crash
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115301/#review48233
-----------------------------------------------------------
On Jan. 24, 2014, 4:40 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115301/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 4:40 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> As we decided to make the OSD available only for certain things, the API is \
> intentionally limited to very particular set of things. The list is not complete \
> yet I believe, but I'd like to get comments on the general design and state.
> Also as it's not a public service, I left it under org.kde.plasma_shell on D-Bus. \
> Makes sense? Does not? Should it be standalone at eg. org.kde.osd?
> Note: This still needs patches in kwin.
>
>
> Diffs
> -----
>
> src/shell/shellmanager.cpp 1188b48
> src/shell/osd.cpp PRE-CREATION
> src/shell/osd.h PRE-CREATION
> src/shell/CMakeLists.txt 5c4b360
>
> Diff: https://git.reviewboard.kde.org/r/115301/diff/
>
>
> Testing
> -------
>
> Can be invoked using qdbus from command line. Works rather well.
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115301/">https://git.reviewboard.kde.org/r/115301/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 24th, 2014, 4:56 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115301/diff/1/?file=240477#file240477line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/shell/osd.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">118</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QWindow</span> <span class="o">*</span><span class="n">window</span> <span \
class="o">=</span> <span class="n">qobject_cast</span><span \
class="o"><</span><span class="n">QWindow</span><span class="o">*></span><span \
class="p">(</span><span class="n">m_osdWindow</span><span class="o">-></span><span \
class="n">rootObject</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems a bit risky?
Is it relying on the root item being a Plasma.Dialog?
Given we load from a look & feel package which anyone can alter at least qFatal \
with an appropriate error message.
Probably do this on show() as that's going to be called before hide(). </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if it \
doesn't anymore use qwindow directly, it can just set the "visible" \
property on it.. would then be on the responsibility of the osd root object to \
implement a visible property if it isn't using Dialog, but anyways, no \
crash</pre> <br />
<p>- Marco</p>
<br />
<p>On January 24th, 2014, 4:40 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 4:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As we decided to make the OSD available only for certain things, the API \
is intentionally limited to very particular set of things. The list is not complete \
yet I believe, but I'd like to get comments on the general design and state.
Also as it's not a public service, I left it under org.kde.plasma_shell on D-Bus. \
Makes sense? Does not? Should it be standalone at eg. org.kde.osd?
Note: This still needs patches in kwin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Can be invoked using qdbus from command line. Works rather well.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/shell/shellmanager.cpp <span style="color: grey">(1188b48)</span></li>
<li>src/shell/osd.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/shell/osd.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/shell/CMakeLists.txt <span style="color: grey">(5c4b360)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115301/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic