'Re: Review Request 115260: Add default OSD to look&feel package (screenshot included)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115260: Add default OSD to look&feel package (screenshot included)
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2014-01-24 12:17:08
Message-ID: 20140124121708.10270.18578 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115260/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 12:17 p.m.)

Status
------

This change has been marked as submitted.

Review request for kde-workspace and Plasma.

Repository: kde-workspace

Description
-------

Adds the default OSD look&feel file to the default package.

The OSD features just an icon and (a progress bar OR a text). It uses standard Plasma \
components for drawing things, Marco has on his todo list to turn the progress bar \
black, will look better when that's done.

When the OSD is showing progress, no text is shown (can be overriden by the look&feel \
package). 

Diffs
-----

  plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115260/diff/

Testing
-------

File Attachments
----------------

screenshot with default theme
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/23/a864bc46-27b8-411b-9362-03c1fb6a3bbc__osd.png

Thanks,

Martin Klapetek

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115260/">https://git.reviewboard.kde.org/r/115260/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace and Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated Jan. 24, 2014, 12:17 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds the default OSD look&amp;feel file to the default package.

The OSD features just an icon and (a progress bar OR a text). It uses standard Plasma \
components for drawing things, Marco has on his todo list to turn the progress bar \
black, will look better when that&#39;s done.

When the OSD is showing progress, no text is shown (can be overriden by the \
look&amp;feel package). </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115260/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/23/a864bc46-27b8-411b-9362-03c1fb6a3bbc__osd.png">screenshot \
with default theme</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 