[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 115284: Provide KFormat wrapper as QML plugin
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-01-24 12:16:01
Message-ID: 20140124121601.10270.35724 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115284/#review48195
-----------------------------------------------------------
err, this is actually a qml binding for a class in a framework that is external from \
plasma.
I can already see random applications doing their own binding because of not wanting \
to depend from plasma core
being in kcoreaddons, the "right" way, should be really to do an import for \
kcoreaddons in its framework
- Marco Martin
On Jan. 24, 2014, 11:28 a.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115284/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 11:28 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> In Plasma1 KLocale wrapper was used to format different things like duration, it \
> was removed and also KLocale was split up so here is KFormat wrapper to use this \
> methods.
> I found no better place then qtextracomponents, should be different import?
>
>
> Diffs
> -----
>
> src/declarativeimports/core/CMakeLists.txt 71f2cb3
> src/declarativeimports/core/corebindingsplugin.cpp acc7cb7
> src/declarativeimports/core/formats.h PRE-CREATION
> src/declarativeimports/core/formats.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115284/diff/
>
>
> Testing
> -------
>
> Tested formatDuration in battery monitor.
>
>
> Thanks,
>
> Bhushan Shah
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115284/">https://git.reviewboard.kde.org/r/115284/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">err, this is actually a \
qml binding for a class in a framework that is external from plasma.
I can already see random applications doing their own binding because of not wanting \
to depend from plasma core
being in kcoreaddons, the "right" way, should be really to do an import for \
kcoreaddons in its framework</pre> <br />
<p>- Marco Martin</p>
<br />
<p>On January 24th, 2014, 11:28 a.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 11:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In Plasma1 KLocale wrapper was used to format different things like \
duration, it was removed and also KLocale was split up so here is KFormat wrapper to \
use this methods.
I found no better place then qtextracomponents, should be different import?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested formatDuration in battery monitor.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(71f2cb3)</span></li>
<li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: \
grey">(acc7cb7)</span></li>
<li>src/declarativeimports/core/formats.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/core/formats.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115284/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic