'Re: Review Request 115162: Launch single instance of plasma-mediacenter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115162: Launch single instance of plasma-mediacenter
From:       "Sujith Haridasan" <sujith.h () gmail ! com>
Date:       2014-01-22 6:38:28
Message-ID: 20140122063828.17756.8948 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115162/
-----------------------------------------------------------

(Updated Jan. 22, 2014, 6:38 a.m.)

Review request for Plasma, Shantanu Tushar and Sinny Kumari.

Changes
-------

Modified the code to address the issues pointed out by Shantanu.

Repository: plasma-mediacenter

Description
-------

Launching single instance of plasma-mediacenter. Using KUniqueApplication only single \
instance of plasma-mediacenter is launched.

Diffs (updated)
-----

  shells/newshell/application.h PRE-CREATION 
  shells/newshell/application.cpp PRE-CREATION 
  shells/newshell/main.cpp 9fd5df3 
  shells/newshell/mainwindow.h 5e0753e 
  shells/newshell/mainwindow.cpp 1bf56ac 
  shells/newshell/plasma-mediacenter.desktop c3c5781 
  shells/newshell/CMakeLists.txt 60949df 

Diff: https://git.reviewboard.kde.org/r/115162/diff/

Testing
-------

Tests done using konsole:
a) Open a tab and launch pmc.
b) Open another tab and try to launch another instance of pmc.
c) After executing (b) pmc wont launch because already another instance of pmc from \
(a) is already running.

Tests done using Dolphin:
a) Go to the music folder and right click on the file to be played. Click open with \
and launch pmc. b) Try to open another file using same step as (a)
c) After executing (b) wait for few seconds and you can see that only single instance \
of (a) will be running.

Thanks,

Sujith Haridasan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115162/">https://git.reviewboard.kde.org/r/115162/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>

<p style="color: grey;"><i>Updated Jan. 22, 2014, 6:38 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Modified the code to address the issues pointed out by Shantanu.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Launching single instance of plasma-mediacenter. Using \
KUniqueApplication only single instance of plasma-mediacenter is launched.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests done using konsole: a) Open a tab and launch pmc.
b) Open another tab and try to launch another instance of pmc.
c) After executing (b) pmc wont launch because already another instance of pmc from \
(a) is already running.

Tests done using Dolphin:
a) Go to the music folder and right click on the file to be played. Click open with \
and launch pmc. b) Try to open another file using same step as (a)
c) After executing (b) wait for few seconds and you can see that only single instance \
of (a) will be running.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>shells/newshell/application.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>shells/newshell/application.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>shells/newshell/main.cpp <span style="color: grey">(9fd5df3)</span></li>

 <li>shells/newshell/mainwindow.h <span style="color: grey">(5e0753e)</span></li>

 <li>shells/newshell/mainwindow.cpp <span style="color: grey">(1bf56ac)</span></li>

 <li>shells/newshell/plasma-mediacenter.desktop <span style="color: \
grey">(c3c5781)</span></li>

 <li>shells/newshell/CMakeLists.txt <span style="color: grey">(60949df)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115162/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 