'Re: Review Request 115046: Reduce timeout of startupfeedback to a sensible default'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115046: Reduce timeout of startupfeedback to a sensible default
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-01-20 16:05:29
Message-ID: 20140120160529.7096.66557 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115046/
-----------------------------------------------------------

(Updated Jan. 20, 2014, 4:05 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: kde-workspace

Description
-------

It's 2014 and we don't have to wait half a minute for an application to start.
In fact we mostly get false positives due to applications not handling correctly
startup notifications for already running instances (e.g. click on link in email).

So let's reduce to a default which doesn't look like a broken setup.

Diffs
-----

  kcontrol/launch/kcmlaunch.cpp fc9543e 
  kwin/effects/startupfeedback/startupfeedback.cpp d700138 
  libs/taskmanager/taskmanager.cpp 2b3bdc5 

Diff: https://git.reviewboard.kde.org/r/115046/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115046/">https://git.reviewboard.kde.org/r/115046/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2014, 4:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s 2014 and we don&#39;t have to wait half a minute for an \
application to start. In fact we mostly get false positives due to applications not \
handling correctly startup notifications for already running instances (e.g. click on \
link in email).

So let&#39;s reduce to a default which doesn&#39;t look like a broken setup.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/launch/kcmlaunch.cpp <span style="color: grey">(fc9543e)</span></li>

 <li>kwin/effects/startupfeedback/startupfeedback.cpp <span style="color: \
grey">(d700138)</span></li>

 <li>libs/taskmanager/taskmanager.cpp <span style="color: grey">(2b3bdc5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115046/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 